Stop paying attention to PatchConfig.props #16748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougbu
added
the
area-infrastructure
JunTaoLuo
approved these changes
Nov 1, 2019
dougbu
force-pushed
the
dougbu-patch-1
branch
from
f125d75 to
e86cb5b
Compare
Agreed. I rebased on current 'release/3.0' to pick up stabilization setting. |
dougbu
added
the
ask-mode
- also delete the file itself
dougbu
force-pushed
the
dougbu-patch-1
branch
from
e86cb5b to
82e020e
Compare
dougbu
requested review from
analogrelay,
BrennanConroy,
halter73 and
mikaelm12
as code owners
|
Fired off a new additional test build at https://dev.azure.com/dnceng/internal/_build/results?buildId=423518&view=results |
|
/bump reviewers |
|
Asking for another review because this is no longer a one-liner |
wtgodbe
approved these changes
Nov 12, 2019
leecow
added
Servicing-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The ASP.NET Core team has hit repeated issues in servicing with merging fixes and not shipping the affected packages. 3.0 and later branches ship far fewer packages than 2.x and we have no (LZMA) downsides to shipping everything. The ASP.NET Core team thus decided to simplify the infrastructure and remove the previous ship / no-ship controls (in PatchConfig.props). This PR
does the minimum change to simply ignore that filecompletely removes the PatchConfig.props file and all references to it.We will probably follow up in 2.x branches to change the approach, automating what ships more extensively and removing the need for manual PatchConfig.props changes. That is not this change.
Small exception
"Everything" does not include the targeting packs or Microsoft.AspNetCore.App.Ref. We do not normally service those.
Customer Impact
Never miss a fix after a servicing upgrade
Regression?
No
Testing
PR validation build includes stable versioning and published everything. This can be observed in the Source_Build_Packages and Windows_Packages listings at https://dev.azure.com/dnceng/public/_build/results?buildId=415240&view=artifacts
Small exception
Microsoft.AspNetCore.App.Ref and the targeting packs were produced in that build. That's due to the 3.0.1 special case.
Risk
Low.