Skip to content

Cleanup kestrel Win10 skips #16756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2019
Merged

Cleanup kestrel Win10 skips #16756

merged 1 commit into from
Nov 4, 2019

Conversation

Tratcher
Copy link
Member

@Tratcher Tratcher commented Nov 1, 2019

#14382
https://github.com/aspnet/AspNetCore/pull/15228/files didn't merge cleanly from 3.1 to master because the tests had been skipped in different ways in different branches. SkipOnHelix is no longer needed because MinimumOSVersion Win10_RS4 now accurately covers the dependency.

#3170 tracks getting a helix queue setup for testing the latest versions of windows. These tests will automatically light up there.

@Tratcher Tratcher added this to the 5.0.0-preview1 milestone Nov 1, 2019
@Tratcher Tratcher requested review from halter73 and HaoK November 1, 2019 22:19
@Tratcher Tratcher self-assigned this Nov 1, 2019
@Tratcher
Copy link
Member Author

Tratcher commented Nov 4, 2019

Munday bump

@Tratcher Tratcher merged commit 87bd1be into master Nov 4, 2019
@Tratcher Tratcher deleted the tratcher/win10skip branch November 4, 2019 21:32
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants