Do not always build the targeting pack archives

[mmitche]

No description provided.

[wtgodbe]

Would be interested to know why this didn't surface before servicing builds, but that's a question for later

[wtgodbe]

CC @JunTaoLuo @dougbu

[dougbu]

This may work but is likely glossing over a deeper problem.

---

$(OnlyPackPlatformSpecificPackages) is no longer honoured for the .Ref package. The main problem is at https://github.com/aspnet/AspNetCore/blob/release/3.0/src/Framework/ref/Microsoft.AspNetCore.App.Ref.csproj#L211

Where before $(OnlyPackPlatformSpecificPackages) ensured $(IsPackable) was false for the generic .Ref project and therefore the package wasn't built, the new $(IsTargetingPackPatching) property takes precedence.

@JunTaoLuo @wtgodbe why do both $(IsTargetingPackPatching) and $(IsTargetingPackBuilding) exist? And, if they're both necessary, why aren't both used to set $(IsPackable) earlier in the .Ref project (here)?

---

@mmitche I recommend changing https://github.com/aspnet/AspNetCore/blob/release/3.0/src/Framework/ref/Microsoft.AspNetCore.App.Ref.csproj#L7-L8 (to include $(IsTargetingPackPatching) in the condition) instead of anything in Publishing .props. Also back out the use of $(IsTargetingPackPatching) at https://github.com/aspnet/AspNetCore/blob/release/3.0/src/Framework/ref/Microsoft.AspNetCore.App.Ref.csproj#L211

We can remove $(IsTargetingPackPatching) later…

[wtgodbe]

IsTargetingPackPatching really means "Is this 3.0.1?". we use it for some special logic in ResolveReferences.targets

[mmitche]

@wtgodbe @JunTaoLuo @dougbu I'll leave it to you to decide whether this is okay to take or whether another fix is needed. Merge as desired.

[wtgodbe]

@dougbu I'm confused by your suggestion - IsTargetingPackPatching is just based off of whether or not we're building 3.0.1. Adding it as a condition to https://github.com/aspnet/AspNetCore/blob/release/3.0/src/Framework/ref/Microsoft.AspNetCore.App.Ref.csproj#L7-L8 wouldn't change the behavior

[wtgodbe]

Ah, never mind, I missed the part about https://github.com/aspnet/AspNetCore/blob/602cb1dea59751a1297d674cddf7f0729c23e6ca/Directory.Build.targets#L5. I think all we need to do is back out IsTargetingPackPatching from https://github.com/aspnet/AspNetCore/blob/release/3.0/src/Framework/ref/Microsoft.AspNetCore.App.Ref.csproj#L211, as the IsPackable setting from https://github.com/aspnet/AspNetCore/blob/release/3.0/src/Framework/ref/Microsoft.AspNetCore.App.Ref.csproj#L7-L8 will be overwritten by d.b.t. Does that sound correct?

[dougbu]

Does that sound correct?

Yup, glad I wasn't delusional. Let me know if you want me to create another PR for that one-liner. Not sure reusing this PR makes sense.

[mmitche]

I've changed this PR to use will's suggestion and run an internal build to test.

[dougbu]

thanx @mmitche❕❕

[JunTaoLuo]

Rerunning flaky test.