Skip to content

[release/3.1] Update dependencies from aspnet/EntityFrameworkCore #16818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2019
Merged

[release/3.1] Update dependencies from aspnet/EntityFrameworkCore #16818

merged 1 commit into from
Nov 5, 2019

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Nov 4, 2019

This pull request updates the following dependencies

From https://github.com/aspnet/EntityFrameworkCore

  • Build: 20191104.3
  • Date Produced: 11/4/2019 5:12 PM
  • Commit: b7ef9ec472b2d25cca70e3c9b4ab3a1032d275d5
  • Branch: refs/heads/release/3.1
  • Updates:
    • Microsoft.EntityFrameworkCore.Tools -> 3.1.0-preview3.19554.3
    • Microsoft.EntityFrameworkCore.SqlServer -> 3.1.0-preview3.19554.3
    • dotnet-ef -> 3.1.0-preview3.19554.3
    • Microsoft.EntityFrameworkCore -> 3.1.0-preview3.19554.3
    • Microsoft.EntityFrameworkCore.InMemory -> 3.1.0-preview3.19554.3
    • Microsoft.EntityFrameworkCore.Relational -> 3.1.0-preview3.19554.3
    • Microsoft.EntityFrameworkCore.Sqlite -> 3.1.0-preview3.19554.3

@dotnet-maestro
Update dependencies from https://github.com/aspnet/EntityFrameworkCore …
1e75cdb 
…build 20191104.3

- Microsoft.EntityFrameworkCore.Tools - 3.1.0-preview3.19554.3
- Microsoft.EntityFrameworkCore.SqlServer - 3.1.0-preview3.19554.3
- dotnet-ef - 3.1.0-preview3.19554.3
- Microsoft.EntityFrameworkCore - 3.1.0-preview3.19554.3
- Microsoft.EntityFrameworkCore.InMemory - 3.1.0-preview3.19554.3
- Microsoft.EntityFrameworkCore.Relational - 3.1.0-preview3.19554.3
- Microsoft.EntityFrameworkCore.Sqlite - 3.1.0-preview3.19554.3
@dotnet-maestro dotnet-maestro bot requested a review from dougbu as a code owner November 4, 2019 18:50
@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Nov 4, 2019 •
edited
Loading

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❓ Waiting on checks: AspNetCore-ci, AspNetCore-ci (Build Test: Templates - Windows Server 2016 x64)
  • ❌ No Requested Changes There are reviews that have requested changes.

dougbu
dougbu suggested changes Nov 4, 2019
View reviewed changes
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holding off 'til we decide to flow this change.

@dougbu dougbu added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Nov 4, 2019
@wtgodbe
Copy link
Member

wtgodbe commented Nov 4, 2019

Actually @dougbu we should merge this once CI finishes. We already have a 3.1-preview3 build, so it won't harm us to get the ball rolling on dependency flow here, so that if we decide to take this we can have the 2nd build ready to go.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Nov 4, 2019 •
edited
Loading

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ All Checks Successful Unsuccessful checks: AspNetCore-ci, AspNetCore-ci (Build Test: Templates - Windows Server 2016 x64)
  • ❌ No Requested Changes There are reviews that have requested changes.

@dougbu
Copy link
Contributor

dougbu commented Nov 4, 2019

@wtgodbe this build didn't succeed and I'm not sure I agree. Would be fine if the EFCore change were approved for -preview3. But, will have more to unravel if something else is approved e.g. the change already in AspNetCore.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Nov 4, 2019 •
edited
Loading

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❓ Waiting on checks: AspNetCore-ci, AspNetCore-ci (Build Test: Templates - Windows Server 2016 x64)
  • ❌ No Requested Changes There are reviews that have requested changes.

@wtgodbe
Copy link
Member

wtgodbe commented Nov 5, 2019

The change that triggered that has been approved for preview3, I'll move ahead with this if it passes CI.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Nov 5, 2019 •
edited
Loading

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❓ Waiting on checks: AspNetCore-ci, AspNetCore-ci (Build Test: Templates - Windows Server 2016 x64)
  • ❌ No Requested Changes There are reviews that have requested changes.

dougbu
dougbu approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Withdrawing my block here. Expect another build from EFCore after this one.

@wtgodbe wtgodbe merged commit e8f59e6 into release/3.1 Nov 5, 2019
@wtgodbe wtgodbe deleted the darc-release/3.1-32bd8948-af6c-4a9e-bacf-2fb8bb198fa1 branch November 5, 2019 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbu dougbu dougbu approved these changes

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wtgodbe @dougbu