Keep Blazor at pre-release for 3.1 #16829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougbu
suggested changes
Nov 4, 2019
| @@ -19,6 +19,9 @@ | |||
| <IncludePreReleaseLabelInPackageVersion Condition=" '$(DotNetFinalVersionKind)' == 'release' ">false</IncludePreReleaseLabelInPackageVersion> | |||
| <PreReleaseVersionLabel>preview$(PreReleasePreviewNumber)</PreReleaseVersionLabel> | |||
| <PreReleaseBrandingLabel>Preview $(PreReleasePreviewNumber)</PreReleaseBrandingLabel> | |||
| <!-- Blazor Client packages will not RTM with 3.1 --> | |||
| <BlazorClientPreReleasePreviewNumber>4</BlazorClientPreReleasePreviewNumber> | |||
There was a problem hiding this comment.
Suggested change
| <BlazorClientPreReleasePreviewNumber>4</BlazorClientPreReleasePreviewNumber> | |
| <BlazorClientPreReleasePreviewNumber>3</BlazorClientPreReleasePreviewNumber> |
Don't jump ahead of $(PreReleasePreviewNumber). We can change this when stabilizing versions and removing the other property.
|
Yea this shouldn't be merged until we have branding updates for GA. |
|
I'll merge this when I update branding to stable Sunday/Monday |
|
@wtgodbe are these ready to go in yet? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the following Blazor packages remain branded as 3.1.x-preview4:
• Microsoft.AspNetCore.Blazor
• Microsoft.AspNetCore.Blazor.HttpClient
• Microsoft.AspNetCore.Blazor.DataAnnotations.Validation
• Microsoft.AspNetCore.Blazor.Templates
• Microsoft.AspNetCore.Blazor.Build
• Microsoft.AspNetCore.Blazor.Mono
• Microsoft.AspNetCore.Blazor.Server
• Microsoft.AspNetCore.Blazor.DevServer
Note that Microsoft.AspNetCore.Blazor.Mono is built in aspnet/Blazor so that will require a different branding change.