Skip to content

Change how we resolve dotnet in tests (#16934) #16949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2019
Merged

Conversation

BrennanConroy
Copy link
Member

Cherry-pick #16934 from release/3.0

@BrennanConroy BrennanConroy added the tell-mode Indicates a PR which is being merged during tell-mode label Nov 10, 2019
@BrennanConroy BrennanConroy added this to the 3.1.0 milestone Nov 10, 2019
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please hold off 'til preview3 is out

@wtgodbe
Copy link
Member

wtgodbe commented Nov 10, 2019

@wtgodbe merge this one first for GA

@BrennanConroy
Copy link
Member Author

@wtgodbe merge this one first for GA

Are you going to take care of the merge then?

@wtgodbe
Copy link
Member

wtgodbe commented Nov 10, 2019

Are you going to take care of the merge then?

Yezzir, I'll merge this with the rest of the batch Monday morning

@analogrelay
Copy link
Contributor

Fixes #16912 ?

@BrennanConroy
Copy link
Member Author

Fixes #16912 ?

Yes, but I don't want to put that in the summary until we un-skip the tests on master

@wtgodbe wtgodbe merged commit b90b550 into release/3.1 Nov 11, 2019
@wtgodbe wtgodbe deleted the brecon/forward branch November 11, 2019 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants