[3.1.x] Fix dotnet.exe process recovery after abnormal exit in ANCM #17103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotalik
changed the title
Tratcher
reviewed
Nov 14, 2019
src/Servers/IIS/AspNetCoreModuleV2/OutOfProcessRequestHandler/serverprocess.cpp
Outdated
Show resolved
Hide resolved
src/Servers/IIS/AspNetCoreModuleV2/OutOfProcessRequestHandler/serverprocess.cpp
Outdated
Show resolved
Hide resolved
src/Servers/IIS/AspNetCoreModuleV2/OutOfProcessRequestHandler/serverprocess.cpp
Outdated
Show resolved
Hide resolved
halter73
reviewed
Nov 14, 2019
src/Servers/IIS/AspNetCoreModuleV2/RequestHandlerLib/requesthandler_config.h
Show resolved
Hide resolved
halter73
reviewed
Nov 14, 2019
Co-Authored-By: Andrew Stanton-Nurse <[email protected]>
src/Servers/IIS/IIS/test/Common.FunctionalTests/OutOfProcess/AspNetCorePortTests.cs
Show resolved
Hide resolved
src/Servers/IIS/AspNetCoreModuleV2/OutOfProcessRequestHandler/serverprocess.cpp
Outdated
Show resolved
Hide resolved
|
Please apply |
analogrelay
changed the title
…serverprocess.cpp Co-Authored-By: Brennan <[email protected]>
|
We'll also patch this in the 3.0 branch/sdk? |
|
@Tratcher from what I heard, no. |
BrennanConroy
approved these changes
Nov 20, 2019
src/Servers/IIS/IIS/test/Common.FunctionalTests/OutOfProcess/AspNetCorePortTests.cs
Show resolved
Hide resolved
| for (var i = 0; i < 10; i++) | ||
| { | ||
| // ANCM should eventually recover from being shutdown multiple times. | ||
| response = await deploymentResult.HttpClient.GetAsync("/HelloWorld"); |
There was a problem hiding this comment.
The test is a bit... ugly.
src/Servers/IIS/IIS/test/Common.FunctionalTests/OutOfProcess/AspNetCorePortTests.cs
Show resolved
Hide resolved
halter73
approved these changes
Nov 20, 2019
SetCurrentDirectory and CallStartupHook both default to true. |
analogrelay
added
the
Servicing-consider
analogrelay
changed the title
leecow
added
Servicing-approved
|
Do we have to wait for branding or can we merge these now? I believe our deadline for 3.1.1 is today. @aspnet/build |
|
These can be merged |
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17063.
Description
We introduced a regression between 2.2 and 3.0/3.1 where ANCM out of process wouldn't restart dotnet.exe on crash after restarting once. This was due to a background thread hanging when trying to close a handle for stdout. Also adds an opt-out switch to remove all redirection s.t. if there are still issues with this code-path, we can disable it.
Risk
Medium, but with reduced risk. Any change to ANCM out-of-process is always risky, but giving an opt-out switch should reduce the risk.
User impact
On application crash, ANCM normally would start a new dotnet.exe to restart dotnet. However, because a call to CloseHandle would hang, the static callback we registered wouldn't be overwritten. Therefore, on the next process exit, the callback wouldn't be fired, meaning all subsequent crashes wouldn't be detected.
Workarounds
If people expect their applications to crash or exit abnormally, they can work around this by either using ANCMv1 or enabling stdout logging. Both of these are non-ideal work arounds.
cc @Pilchie