Add support for IAsyncEnumerable<T> where T is value type #17154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area-mvc
rynowak
reviewed
Nov 15, 2019
| } | ||
|
|
||
| private async Task<ICollection> ReadInternal<T>(IAsyncEnumerable<object> value) | ||
| private async Task<ICollection> ReadInternal<T>(object value) |
There was a problem hiding this comment.
This is way smaller of a change than I expected.
rynowak
reviewed
Nov 15, 2019
| Assert.Equal(new[] { "0", "1", "2", }, collection); | ||
| } | ||
|
|
||
| [Fact] | ||
| public async Task ReadAsync_ReadsIAsyncEnumerable_ImplementingMultipleAsyncEnumerableInterfaces() | ||
| public async Task TryGetReader_ReturnsReaderForIAsyncEnumerableOfValueType() |
rynowak
reviewed
Nov 15, 2019
| } | ||
|
|
||
| [Fact] | ||
| public void TryGetReader_ReturnsCachedDelegate() |
There was a problem hiding this comment.
How does this behave when a type implements multiple IAsyncEnumerables<>
There was a problem hiding this comment.
We cache this based on the passed in type, so it just works. I added a test for good measure.
rynowak
approved these changes
Nov 15, 2019
pranavkm
added a commit
that referenced
this pull request
Dec 3, 2019
* Add support for IAsyncEnumerable<T> where T is value type Fixes #17139
pranavkm
added a commit
that referenced
this pull request
Jan 15, 2020
* Add support for IAsyncEnumerable<T> where T is value type Fixes #17139
mkArtakMSFT
pushed a commit
that referenced
this pull request
Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17139