Use System.Reflection.Metadata to generate BootConfig #17156
Conversation
pranavkm
commented
Nov 15, 2019
pranavkm
commented
- Remove reference to Mono.Cecil
- Remove support for auto embedded css \ js
src/Components/Blazor/Build/src/Core/RuntimeDependenciesResolver.cs
Outdated
Show resolved
Hide resolved
|
|
||
| return referencedAssemblyCandidate; | ||
| return Bcl.FirstOrDefault(c => c.Name == assemblyName) ?? | ||
| Dependencies.FirstOrDefault(c => c.Name == assemblyName); |
There was a problem hiding this comment.
Do you think the O(N^2)-ness of this could become an issue if there's a really large number of dependencies? Is it work making Bcl and Dependencies into a dictionary mapping name to AssemblyEntry?
I'm not insisting this should be done; just asking what you think.
There was a problem hiding this comment.
We could turn these in to dictionary lookups. We're generally optimizing for CPU in these processes \ tasks, not memory, so allocating an additional pair of dictionaries should be fine. I'll make the change in an update.
* Remove reference to Mono.Cecil * Remove support for auto embedded css \ js
* Rename some contract types * Remove blazor.webassembly.js
pranavkm
force-pushed
the
prkrishn/more-cleanup
branch
from
f8dd670 to
632f8f3
Compare
| @@ -1,2 +1,3 @@ | |||
| node_modules/ | |||
| dist/Debug/ | |||
| dist/Release/blazor.webassembly.js | |||
There was a problem hiding this comment.
AFAIK this isn't part of the shared framework \ source build, so it doesn't need to be checked in. Correct me if I'm wrong.
| @@ -623,28 +623,20 @@ | |||
| Inputs="$(BlazorBuildBootJsonInputsCache);@(_BlazorDependencyInput)" | |||
| Outputs="$(BlazorBootJsonIntermediateOutputPath)"> | |||
| <ItemGroup> | |||
| <_UnlinkedAppReferencesPaths Include="@(_BlazorDependencyInput)" /> | |||
| <_AppReferences Include="@(BlazorItemOutput->WithMetadataValue('Type','Assembly')->WithMetadataValue('PrimaryOutput','')->'%(FileName)%(Extension)')" /> | |||
| <_AppReferences Include="@(BlazorItemOutput->WithMetadataValue('Type','Assembly')->'%(FileName)%(Extension)')" /> | |||
There was a problem hiding this comment.
These names get better in the next PR when it turns in to a Task. I'm leaving this as-is for now.
