Enable WASM debugging #17162

ryanbrandenburg · 2019-11-16T00:21:41Z

Most of this code is from @SteveSandersonMS, I basically only merged it into the blazor-wasm branch, fixed merge problems, then @ajaybhargavb and I proved that it can work.

This currently works with VSCode (with the Chrome Debugging extension) and VS (through a multi-step process of attaching to the process). It does NOT work on the "F5 experience", but my understanding is that that's a tooling issue on the VS side.

Steps for running through this in VSCode:

Install the Chrome debugging extension.
Launch your app in debug mode and navigate to it on a chrome tab with debug on (Ctrl-F5 in VS was how we did it).
In a blazorwasm app create a new debug launch profile of type "Chrome attach".
Launch the profile from above.
Set a breakpoint and take an action which causes it to be hit.

CC @danroth27

src/Components/Blazor/Server/src/MonoDebugProxy/ws-proxy/DebugStore.cs

eng/ProjectReferences.props

pranavkm

Would you like to demo this feature during the blazor sync up?

eng/ProjectReferences.props

pranavkm · 2019-11-18T17:12:15Z

src/Components/Blazor/Server/src/MonoDebugProxy/BlazorMonoDebugProxyAppBuilderExtensions.cs

+            {
+                var request = context.Request;
+                var requestPath = request.Path;
+                if (requestPath.StartsWithSegments("/json")


@rynowak could this be changed to use endpoint routing?

It could be, but that's a big user-experience change. Let's not blocks this PR on that.

src/Components/Blazor/Server/src/MonoDebugProxy/BlazorMonoDebugProxyAppBuilderExtensions.cs

ryanbrandenburg · 2019-11-18T21:45:01Z

Update.

src/Components/Blazor/Server/src/MonoDebugProxy/BlazorMonoDebugProxyAppBuilderExtensions.cs

… Chrome protocol Hacky so far. This is just a proof-of-concept.

ryanbrandenburg · 2019-11-20T17:58:32Z

🆙📅

SteveSandersonMS · 2019-11-20T18:07:00Z

src/Components/Blazor/Server/src/MonoDebugProxy/BlazorMonoDebugProxyAppBuilderExtensions.cs

+                if (requestPath.StartsWithSegments("/json")
+                    && !request.Headers.ContainsKey("User-Agent"))
+                {
+                    var debuggerHost = "http://localhost:9222";


Eventually we might need to make this port number (and possibly hostname) configurable, but hopefully we will only do that if we find out it's necessary for tooling (e.g., if VS really wants to launch the browser with a nonstandard debugging port). So I'm OK with this as-is for now.

Eventually we might need to make this port number (and possibly hostname) configurable

Wouldn't this fit in launchSettings? I don't know if VS actually picks an unused port to launch IIS Express or simply picks any at random (and might randomly fail), but that seems semantically related.

@chucker This is the port that the browser listens on for debugging, not the port your app runs on. So the correct value depends on how you (or the IDE) started up your browser.

@ryanbrandenburg

OK, we've learned now thanks to a meeting with VS and web tools people that we do need to make this into a parameter. We're thinking it should be an environment variable. So:

If the environment variable ASPNETCORE_WEBASSEMBLYDEBUGHOST is set, we should use that value for debuggerHost. The value will be something like http://localhost:49573 as an example.

Otherwise we keep using http://localhost:9222

Do you think that's a change we could include in this PR?

Update: Sorry @pranavkm for notifying you last time. I got mixed up about which PR this was. I know you're not doing this one!

SteveSandersonMS

Looks great!

ryanbrandenburg · 2019-11-22T19:57:22Z

@SteveSandersonMS can I get you to give one last review to just the latest commit since I had to change behavior somewhat?

src/Components/Blazor/Server/src/MonoDebugProxy/BlazorMonoDebugProxyAppBuilderExtensions.cs

ryanbrandenburg requested review from pranavkm, SteveSandersonMS and ajaybhargavb November 16, 2019 00:21

ryanbrandenburg requested a review from a team as a code owner November 16, 2019 00:21

ajaybhargavb reviewed Nov 16, 2019

View reviewed changes

src/Components/Blazor/Server/src/MonoDebugProxy/ws-proxy/DebugStore.cs Outdated Show resolved Hide resolved

dougbu reviewed Nov 16, 2019

View reviewed changes

eng/ProjectReferences.props Outdated Show resolved Hide resolved

Pilchie added the area-blazor Includes: Blazor, Razor Components label Nov 18, 2019

pranavkm reviewed Nov 18, 2019

View reviewed changes

SteveSandersonMS reviewed Nov 18, 2019

View reviewed changes

src/Components/Blazor/Server/src/MonoDebugProxy/BlazorMonoDebugProxyAppBuilderExtensions.cs Outdated Show resolved Hide resolved

SteveSandersonMS reviewed Nov 18, 2019

View reviewed changes

src/Components/Blazor/Server/src/MonoDebugProxy/BlazorMonoDebugProxyAppBuilderExtensions.cs Outdated Show resolved Hide resolved

SteveSandersonMS and others added 6 commits November 20, 2019 09:43

Changes needed so VS can connect to the Mono WebAssembly debugger via…

91db20f

… Chrome protocol Hacky so far. This is just a proof-of-concept.

StandaloneApp debuggin works

b8e2fa2

Cleanup

556cb4e

PR feedback

f6fa52b

PR feedback

c8d62ce

PR feedback

4b8f293

ryanbrandenburg force-pushed the rybrande/WasmDebug branch from c38ca64 to 4b8f293 Compare November 20, 2019 17:55

SteveSandersonMS reviewed Nov 20, 2019

View reviewed changes

SteveSandersonMS self-requested a review November 20, 2019 18:14

SteveSandersonMS approved these changes Nov 20, 2019

View reviewed changes

Remove unneeded ProjectRef

362fe47

rynowak approved these changes Nov 20, 2019

View reviewed changes

PR feedback

2178540

SteveSandersonMS reviewed Nov 22, 2019

View reviewed changes

src/Components/Blazor/Server/src/MonoDebugProxy/BlazorMonoDebugProxyAppBuilderExtensions.cs Outdated Show resolved Hide resolved

SteveSandersonMS approved these changes Nov 22, 2019

View reviewed changes

ryanbrandenburg added 2 commits November 22, 2019 13:10

Generalize port references

caded1d

PR feedback

62225ce

ryanbrandenburg merged commit 03dd93c into blazor-wasm Nov 25, 2019

ryanbrandenburg deleted the rybrande/WasmDebug branch November 25, 2019 21:00

ryanbrandenburg mentioned this pull request Nov 25, 2019

Expose CDP websocket endpoint for WASM debugging #13902

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Enable WASM debugging #17162

Enable WASM debugging #17162

Uh oh!

ryanbrandenburg commented Nov 16, 2019

Uh oh!

Uh oh!

Uh oh!

pranavkm left a comment

Uh oh!

Uh oh!

pranavkm Nov 18, 2019

Uh oh!

rynowak Nov 20, 2019

Uh oh!

Uh oh!

Uh oh!

ryanbrandenburg commented Nov 18, 2019

Uh oh!

Uh oh!

Uh oh!

ryanbrandenburg commented Nov 20, 2019

Uh oh!

SteveSandersonMS Nov 20, 2019

Uh oh!

chucker Nov 20, 2019

Uh oh!

SteveSandersonMS Nov 20, 2019

Uh oh!

SteveSandersonMS Nov 20, 2019 •

edited

Loading

Uh oh!

SteveSandersonMS left a comment

Uh oh!

ryanbrandenburg commented Nov 22, 2019

Uh oh!

Uh oh!

Uh oh!

Enable WASM debugging #17162

Enable WASM debugging #17162

Uh oh!

Conversation

ryanbrandenburg commented Nov 16, 2019

Uh oh!

Uh oh!

Uh oh!

pranavkm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pranavkm Nov 18, 2019

Choose a reason for hiding this comment

Uh oh!

rynowak Nov 20, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ryanbrandenburg commented Nov 18, 2019

Uh oh!

Uh oh!

Uh oh!

ryanbrandenburg commented Nov 20, 2019

Uh oh!

SteveSandersonMS Nov 20, 2019

Choose a reason for hiding this comment

Uh oh!

chucker Nov 20, 2019

Choose a reason for hiding this comment

Uh oh!

SteveSandersonMS Nov 20, 2019

Choose a reason for hiding this comment

Uh oh!

SteveSandersonMS Nov 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SteveSandersonMS left a comment

Choose a reason for hiding this comment

Uh oh!

ryanbrandenburg commented Nov 22, 2019

Uh oh!

Uh oh!

Uh oh!

SteveSandersonMS Nov 20, 2019 •

edited

Loading