[release/3.0] Update dependencies from dotnet/arcade aspnet/Blazor #17270

dotnet-maestro · 2019-11-20T19:34:42Z

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

Build: 20191119.2
Date Produced: 11/19/2019 6:14 PM
Commit: e34d933e18ba1cd393bbafcb6018e0f858d3e89e
Branch: refs/heads/release/3.x
Updates:
- Microsoft.DotNet.Arcade.Sdk -> 1.0.0-beta.19569.2
- Microsoft.DotNet.GenAPI -> 1.0.0-beta.19569.2
- Microsoft.DotNet.Helix.Sdk -> 2.0.0-beta.19569.2

From https://github.com/aspnet/Blazor

Build: 20191120.2
Date Produced: 11/20/2019 9:04 PM
Commit: a10163f767cf263d593836c9249d8314e8948d89
Branch: refs/heads/release/3.0
Updates:
- Microsoft.AspNetCore.Blazor.Mono -> 3.0.0-preview9.19570.2

…119.2 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19569.2 - Microsoft.DotNet.GenAPI - 1.0.0-beta.19569.2 - Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19569.2

dotnet-maestro · 2019-11-20T19:39:45Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ All Checks Successful Unsuccessful checks: AspNetCore-ci (Build Test: Windows Server 2016 x64)
✔️ No Requested Changes Succeeded - No reviews have requested changes.

…120.2 - Microsoft.AspNetCore.Blazor.Mono - 3.0.0-preview9.19570.2

ajaybhargavb · 2019-11-20T22:40:57Z

Test failure,

InputDateInteractsWithEditContext_NullableDateTimeOffset

Assert.Equal() Failure\r\nExpected: modified invalid\r\nActual: modified valid

at Microsoft.AspNetCore.E2ETesting.WaitAssert.<>c__DisplayClass11_0.<WaitAssertCore>b__0(IWebDriver _) in /_/src/Shared/E2ETesting/WaitAssert.cs:line 72
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.AspNetCore.E2ETesting.WaitAssert.WaitAssertCore(IWebDriver driver, Action assertion, TimeSpan timeout) in /_/src/Shared/E2ETesting/WaitAssert.cs:line 91
   at Microsoft.AspNetCore.E2ETesting.WaitAssert.Equal[T](IWebDriver driver, T expected, Func`1 actual) in /_/src/Shared/E2ETesting/WaitAssert.cs:line 21
   at Microsoft.AspNetCore.Components.E2ETest.Tests.FormsTest.InputDateInteractsWithEditContext_NullableDateTimeOffset() in /_/src/Components/test/E2ETest/Tests/FormsTest.cs:line 233

@pranavkm @SteveSandersonMS, have you seen this before? Can you take a look?

dotnet-maestro · 2019-11-20T22:41:12Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ All Checks Successful Unsuccessful checks: AspNetCore-ci (Build Test: Windows Server 2016 x64)
✔️ No Requested Changes Succeeded - No reviews have requested changes.

SteveSandersonMS · 2019-11-20T22:57:07Z

Yes, this test has been a problem for us for a long time. The most recent person looking into it (there have been many) is @ryanbrandenburg (as in https://github.com/aspnet/AspNetCore-Internal/issues/3295#issuecomment-555196029). Ryan, are you planning to mark this test as flaky?

dotnet-maestro · 2019-11-20T23:01:21Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ All Checks Successful Unsuccessful checks: AspNetCore-ci, AspNetCore-ci (Build Test: Windows Server 2016 x64)
✔️ No Requested Changes Succeeded - No reviews have requested changes.

ryanbrandenburg · 2019-11-21T00:04:16Z

I don't have much context on tests like InputDateInteractsWithEditContext_NonNullableDateTime, but it doesn't appear to be a single test with this problem, it's a class of tests starting with InputDate, which we would have to mark all Flaky. If you as someone who knows that area are fine with losing that coverage I can make the change. I just want to be sure we understand what we're getting into.

dotnet-maestro · 2019-11-21T00:06:51Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ All Checks Successful Unsuccessful checks: AspNetCore-ci, AspNetCore-ci (Build Test: Windows Server 2016 x64)
✔️ No Requested Changes Succeeded - No reviews have requested changes.

dougbu

Not merging 'til @mmitche confirms the file deletions are correct and the test failures are resolved

dougbu · 2019-11-21T00:35:40Z

and the test failures are resolved

Should mention I retried the failed jobs in https://dev.azure.com/dnceng/public/_build/results?buildId=433505 Hopefully the next attempt won't hit a different flaky-but-not-so-marked test failure.

dotnet-maestro · 2019-11-21T00:37:05Z

Auto-Merge Status

This pull request will be merged because the following merge policies have succeeded.

✔️ All Checks Successful Succeeded - Successful checks: AspNetCore-ci, AspNetCore-ci (Build Test: Windows Server 2016 x64), AspNetCore-ci (Build Test: Linux Source Build), AspNetCore-ci (Build Test: Ubuntu 16.04 x64), AspNetCore-ci (Build Test: Templates - Windows Server 2016 x64), AspNetCore-ci (Build Test: macOS 10.13), AspNetCore-ci (Build Build: Linux Musl ARM64), AspNetCore-ci (Build Build: Linux x64), AspNetCore-ci (Build Build: Linux Musl x64), AspNetCore-ci (Build Build: Linux ARM64), AspNetCore-ci (Build Build: Linux ARM), AspNetCore-ci (Build Build: macOS), AspNetCore-ci (Build Build: Windows ARM), AspNetCore-ci (Build Code check), AspNetCore-ci (Build Build: Windows x64/x86)
✔️ No Requested Changes Succeeded - No reviews have requested changes.

dougbu · 2019-11-21T03:52:18Z

Got this in because @mmitche confirmed elsewhere that deleting a few eng/common/** files all good and the validation build completed successfully.

Update dependencies from https://github.com/dotnet/arcade build 20191…

49e6134

…119.2 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19569.2 - Microsoft.DotNet.GenAPI - 1.0.0-beta.19569.2 - Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19569.2

dotnet-maestro bot requested review from dougbu and a team as code owners November 20, 2019 19:34

Update dependencies from https://github.com/aspnet/Blazor build 20191…

59884f6

…120.2 - Microsoft.AspNetCore.Blazor.Mono - 3.0.0-preview9.19570.2

dotnet-maestro bot changed the title ~~[release/3.0] Update dependencies from dotnet/arcade~~ [release/3.0] Update dependencies from dotnet/arcade aspnet/Blazor Nov 20, 2019

dougbu reviewed Nov 21, 2019

View reviewed changes

ajaybhargavb approved these changes Nov 21, 2019

View reviewed changes

dougbu merged commit 43ca89b into release/3.0 Nov 21, 2019

dougbu deleted the darc-release/3.0-5a103f41-c1e5-4032-9421-ee68a21173fa branch November 21, 2019 03:51

dougbu added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Nov 21, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[release/3.0] Update dependencies from dotnet/arcade aspnet/Blazor #17270

[release/3.0] Update dependencies from dotnet/arcade aspnet/Blazor #17270

Uh oh!

dotnet-maestro bot commented Nov 20, 2019 •

edited

Loading

Uh oh!

dotnet-maestro bot commented Nov 20, 2019 •

edited

Loading

Uh oh!

ajaybhargavb commented Nov 20, 2019

Uh oh!

dotnet-maestro bot commented Nov 20, 2019 •

edited

Loading

Uh oh!

SteveSandersonMS commented Nov 20, 2019

Uh oh!

dotnet-maestro bot commented Nov 20, 2019 •

edited

Loading

Uh oh!

ryanbrandenburg commented Nov 21, 2019

Uh oh!

dotnet-maestro bot commented Nov 21, 2019 •

edited

Loading

Uh oh!

dougbu left a comment

Uh oh!

dougbu commented Nov 21, 2019

Uh oh!

dotnet-maestro bot commented Nov 21, 2019 •

edited

Loading

Uh oh!

dougbu commented Nov 21, 2019

Uh oh!

Uh oh!

[release/3.0] Update dependencies from dotnet/arcade aspnet/Blazor #17270

[release/3.0] Update dependencies from dotnet/arcade aspnet/Blazor #17270

Uh oh!

Conversation

dotnet-maestro bot commented Nov 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

From https://github.com/dotnet/arcade

From https://github.com/aspnet/Blazor

Uh oh!

dotnet-maestro bot commented Nov 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Auto-Merge Status

Uh oh!

ajaybhargavb commented Nov 20, 2019

Uh oh!

dotnet-maestro bot commented Nov 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Auto-Merge Status

Uh oh!

SteveSandersonMS commented Nov 20, 2019

Uh oh!

dotnet-maestro bot commented Nov 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Auto-Merge Status

Uh oh!

ryanbrandenburg commented Nov 21, 2019

Uh oh!

dotnet-maestro bot commented Nov 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Auto-Merge Status

Uh oh!

dougbu left a comment

Choose a reason for hiding this comment

Uh oh!

dougbu commented Nov 21, 2019

Uh oh!

dotnet-maestro bot commented Nov 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Auto-Merge Status

Uh oh!

dougbu commented Nov 21, 2019

Uh oh!

Uh oh!

dotnet-maestro bot commented Nov 20, 2019 •

edited

Loading

dotnet-maestro bot commented Nov 20, 2019 •

edited

Loading

dotnet-maestro bot commented Nov 20, 2019 •

edited

Loading

dotnet-maestro bot commented Nov 20, 2019 •

edited

Loading

dotnet-maestro bot commented Nov 21, 2019 •

edited

Loading

dotnet-maestro bot commented Nov 21, 2019 •

edited

Loading