Use a task to launch the linker #17313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavkm
force-pushed
the
prkrishn/turn-linker-into-task
branch
from
c358107 to
1ecb165
Compare
pranavkm
changed the base branch from
prkrishn/turn-into-task
to
blazor-wasm
pranavkm
commented
Nov 23, 2019
|
|
||
| protected override void LogEventsFromTextOutput(string singleLine, MessageImportance messageImportance) | ||
| { | ||
| if (!string.IsNullOrEmpty(singleLine) && singleLine.StartsWith("Unhandled exception.", StringComparison.Ordinal)) |
There was a problem hiding this comment.
This is a little iffy, but improves the error reporting experience during dotnet build and in the IDE:
javiercn
approved these changes
Nov 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.