Pool HttpSys request buffers #17314
Merged
Pool HttpSys request buffers #17314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halter73
reviewed
Nov 22, 2019
jkotalik
reviewed
Nov 22, 2019
davidfowl
reviewed
Nov 22, 2019
halter73
approved these changes
Nov 22, 2019
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5849 Finally addressing this perf issue since we have bigger customers moving to core that want Http.Sys. Switching to Kestrel's slab memory pool solves two problems:
A) these 4kb buffers get re-used, cutting GC pressure.
B) the slabs are in the LoH so pinning them doesn't cause fragmentation.
@sebastienros
Scenario: 100k requests over 500 parallel connections.
TLDR: Cut request buffer allocations from 425MB to 9MB
Before:
After using the slab memory pool:
I also tried to use the shared ArrayPool but it was worse here: