Skip to content

Update branding to 3.1.1 #17335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 4, 2019
Merged

Update branding to 3.1.1 #17335

merged 4 commits into from
Dec 4, 2019

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Nov 22, 2019

Update branding & add trigger for internal release/3 branches

@JunTaoLuo @mmitche PTAL

@wtgodbe wtgodbe requested review from dougbu and a team as code owners November 22, 2019 18:46
@wtgodbe wtgodbe requested review from mmitche and JunTaoLuo November 22, 2019 18:48
@wtgodbe
Copy link
Member Author

wtgodbe commented Nov 22, 2019

This will probably fail until we get #17311 in & merge it to 3.1

@Pilchie Pilchie added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Nov 25, 2019
@wtgodbe
Copy link
Member Author

wtgodbe commented Dec 3, 2019

Template failures:

Project new angular --auth Individual failed to publish.\r\nProcess exited with code 1\nStdErr: \nStdOut: Microsoft (R) Build Engine version 16.4.0-preview-19475-01+497296502 for .NET Core\r\nCopyright (C) Microsoft Corporation. All rights reserved.\r\n\r\nF:\workspace.16_work\1\s.dotnet\sdk\3.1.100-preview1-014400\MSBuild.dll -maxcpucount -property:Configuration=Release -restore -target:Publish -verbosity:m /bl .\AspNet.angularindividual.oueksvxrynk.csproj\r\n Restore completed in 23.26 ms for F:\workspace.16_work\1\s\src\ProjectTemplates\test\bin\Release\netcoreapp3.1\TestTemplates\AspNet.angularindividual.oueksvxrynk\AspNet.angularindividual.oueksvxrynk.csproj.\r\n You are using a preview version of .NET Core. See: https://aka.ms/dotnet-core-preview\r\nF:\workspace.16\_work\1\s\.dotnet\sdk\3.1.100-preview1-014400\Microsoft.Common.CurrentVersion.targets(2106,5): warning MSB3106: Assembly strong name "F:\workspace.16_work\1\s\obj\template-restore\microsoft.aspnetcore.app.ref\3.0.0\ref\netcoreapp3.1\Microsoft.AspNetCore.Antiforgery.dll" is either a path which could not be found or it is a full assembly name which is badly formed. If it is a full assembly name it may contain characters that need to be escaped with backslash(). Those characters are Equals(=), Comma(,), Quote("), Apostrophe('), Backslash(). [F:\workspace.16_work\1\s\src\ProjectTemplates\test\bin\Release\netcoreapp3.1\TestTemplates\AspNet.angularindividual.oueksvxrynk\AspNet.angularindividual.oueksvxrynk.csproj]\r\nF:\workspace.16_work\1\s.dotnet\sdk\3.1.100-preview1-014400\Microsoft.Common.CurrentVersion.targets(2106,5): warning MSB3106: Assembly strong name "F:\workspace.16_work\1\s\obj\template-restore\microsoft.aspnetcore.app.ref\3.0.0\ref\netcoreapp3.1\Microsoft.AspNetCore.Authentication.Abstractions.dll" is either a path which could not be found or it is a full assembly name which is badly formed. If it is a full assembly name it may contain characters that need to be escaped with backslash(). Those characters are Equals(=), Comma(,), Quote("), Apostrophe('), Backslash(). [F:\workspace.16_work\1\s\src\ProjectTemplates\test\bin\Release\netcoreapp3.1\TestTemplates\AspNet.angularindividual.oueksvxrynk\AspNet.angularindividual.oueksvxrynk.csproj]\r\nF:\workspace.16_work\1\s.dotnet\sdk\3.1.100-preview1-014400\Microsoft.Common.CurrentVersion.targets(2106,5): warning MSB3106: Assembly strong name "F:\workspace.16_work\1\s\obj\template-restore\microsoft.aspnetcore.app.ref\3.0.0\ref\netcoreapp3.1\Microsoft.AspNetCore.Authentication.Cookies.dll" is either a path which could not be found or it is a full assembly name which is badly formed. If it is a full assembly name it may contain characters that need to be escaped with backslash(). Those characters are Equals(=), Comma(,), Quote("), Apostrophe('), Backslash(). [F:\workspace.16_work\1\s\src\ProjectTemplates\test\bin\Release\netcoreapp3.1\TestTemplates\AspNet.angularindividual.oueksvxrynk\AspNet.angularindividual.oueksvxrynk.csproj]\r\nF:\workspace.16_work\1\s.dotnet\sdk\3.1.100-preview1-014400\Microsoft.Common.CurrentVersion.targets(2106,5): warning MSB3106: Assembly strong name "F:\workspace.16_work\1\s\obj\template-restore\microsoft.aspnetcore.app.ref\3.0.0\ref\netcoreapp3.1\Microsoft.AspNetCore.Authentication.Core.dll" is either a path which could not be found or it is a full assembly name which is badly formed. If it is a full assembly name it may contain characters that need to be escaped with backslash(). Those characters are Equals(=), Comma(,), Quote("), Apostrophe('), Backslash(). [F:\workspace.16_work\1\s\src\ProjectTemplates\test\bin\Release\netcoreapp3.1\TestTemplates\AspNet.angularindividual.oueksvxrynk\AspNet.angularindividual.oueksvxrynk.csproj]\r\nF:\workspace.16_work\1\s.dotnet\sdk\3.1.100-previe

@wtgodbe
Copy link
Member Author

wtgodbe commented Dec 3, 2019

Others are PlatformManifestListsAllFiles and AssembliesAreReferenceAssemblies, which I think we fixed in 3.0. Looking

@wtgodbe
Copy link
Member Author

wtgodbe commented Dec 4, 2019

Oh, we need to update the baseline.

@wtgodbe
Copy link
Member Author

wtgodbe commented Dec 4, 2019

This will fail at least until dotnet-install.sh gets fixed

@wtgodbe wtgodbe merged commit 99979ef into release/3.1 Dec 4, 2019
@wtgodbe wtgodbe deleted the 311 branch December 4, 2019 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants