Skip to content

Update branding for Blazor packages and update baseline #17346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 26, 2019

Conversation

JunTaoLuo
Copy link
Contributor

Addresses parts of https://github.com/aspnet/AspNetCore-Internal/issues/3417.

From local builds I see that Blazor packages are built with non-finalized versions. As a side-effect and non-Blazor packages are built with final versions but I think this is fine.
image

I also checked the nuspec of the Microsoft.AspNetCore.Blazor package and it looks correct to me:

<?xml version="1.0" encoding="utf-8"?>
<package xmlns="http://schemas.microsoft.com/packaging/2013/05/nuspec.xsd">
  <metadata>
    <id>Microsoft.AspNetCore.Blazor</id>
    <version>3.2.0-dev</version>
    <authors>Microsoft</authors>
    <owners>Microsoft</owners>
    <requireLicenseAcceptance>true</requireLicenseAcceptance>
    <license type="expression">Apache-2.0</license>
    <licenseUrl>https://licenses.nuget.org/Apache-2.0</licenseUrl>
    <icon>Icon.png</icon>
    <projectUrl>https://asp.net/</projectUrl>
    <description>Build client-side single-page applications (SPAs) with Blazor running under WebAssembly.

This package was built from the source code at https://github.com/aspnet/AspNetCore/tree/d6c88a36ffe89614be26bf846d64791b9958406b</description>
    <copyright>© Microsoft Corporation. All rights reserved.</copyright>
    <tags>aspnetcore components</tags>
    <serviceable>true</serviceable>
    <repository type="git" url="https://github.com/aspnet/AspNetCore" commit="d6c88a36ffe89614be26bf846d64791b9958406b" />
    <dependencies>
      <group targetFramework=".NETStandard2.1">
        <dependency id="Microsoft.AspNetCore.Components.Web" version="3.1.0" exclude="Build,Analyzers" />
        <dependency id="Microsoft.Extensions.Options" version="3.1.0" exclude="Build,Analyzers" />
        <dependency id="Mono.WebAssembly.Interop" version="3.1.0-preview4.19568.3" exclude="Build,Analyzers" />
      </group>
    </dependencies>
  </metadata>
</package>

It'll be good to have some more eyes on the packages produced, especially the ones we plan on shipping from this branch @javiercn

@@ -3,7 +3,6 @@
<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework>
<StartArguments>-s https://api.nuget.org/v3/index.json</StartArguments>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This way, we can pass in a source via command line. This is redundant anyway since the nuget feed is used by default: https://github.com/aspnet/AspNetCore/blob/master/eng/tools/BaselineGenerator/Program.cs#L50

Copy link
Member

@Pilchie Pilchie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for extra work, but can we hold on the 3.2 versioning for now until it's been reviewed appropriately with directors.

@JunTaoLuo
Copy link
Contributor Author

@Pilchie I reset back to 3.1.0-preview4 for now.

@Pilchie
Copy link
Member

Pilchie commented Nov 25, 2019

Thanks @JunTaoLuo

@Pilchie Pilchie added the area-blazor Includes: Blazor, Razor Components label Nov 25, 2019
@JunTaoLuo JunTaoLuo merged commit 6c961ae into blazor-wasm Nov 26, 2019
@JunTaoLuo JunTaoLuo deleted the johluo/blazor-baseline branch November 26, 2019 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants