-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Update branding for Blazor packages and update baseline #17346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -3,7 +3,6 @@ | |||
<PropertyGroup> | |||
<OutputType>Exe</OutputType> | |||
<TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> | |||
<StartArguments>-s https://api.nuget.org/v3/index.json</StartArguments> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This way, we can pass in a source via command line. This is redundant anyway since the nuget feed is used by default: https://github.com/aspnet/AspNetCore/blob/master/eng/tools/BaselineGenerator/Program.cs#L50
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for extra work, but can we hold on the 3.2 versioning for now until it's been reviewed appropriately with directors.
@Pilchie I reset back to 3.1.0-preview4 for now. |
Thanks @JunTaoLuo |
Addresses parts of https://github.com/aspnet/AspNetCore-Internal/issues/3417.
From local builds I see that Blazor packages are built with non-finalized versions. As a side-effect and non-Blazor packages are built with final versions but I think this is fine.

I also checked the nuspec of the Microsoft.AspNetCore.Blazor package and it looks correct to me:
It'll be good to have some more eyes on the packages produced, especially the ones we plan on shipping from this branch @javiercn