Skip to content

Update ci.yml #17359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2019
Merged

Update ci.yml #17359

merged 1 commit into from
Nov 25, 2019

Conversation

BrennanConroy
Copy link
Member

Not sure how builds are working o.O

@BrennanConroy BrennanConroy added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Nov 23, 2019
@BrennanConroy BrennanConroy requested a review from a team November 23, 2019 20:31
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably my typo. Thanks from Mexico❕

FYI builds are likely working because name / value pairs are just YAML objects with properties name and value. My mistake meant there was instead an object with "name" _SignType and "valule" test. This should be valid YAML even if it didn't enable test signing.

@BrennanConroy
Copy link
Member Author

My mistake meant there was instead an object with "name" _SignType and "valule" test. This should be valid YAML even if it didn't enable test signing.

I got a build failure saying: "/.azure/pipelines/ci.yml (Line: 65, Col: 7): Unexpected value 'valule'" so it somehow was detecting an invalid key-value pair.

@JunTaoLuo JunTaoLuo merged commit 05d579c into release/3.0 Nov 25, 2019
@JunTaoLuo JunTaoLuo deleted the brecon/yml branch November 25, 2019 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants