Added the Blazor survey link to the Blazor-Server project template #17434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkArtakMSFT
added
the
Servicing-consider
danroth27
approved these changes
Nov 26, 2019
ryanbrandenburg
approved these changes
Nov 27, 2019
leecow
added
Servicing-approved
|
Moved to Mar as per Tactics. Will need to be explicitly approved for Feb, if required. |
|
Moving back to 3.1.2 per a later Tactics decision (@jamshedd , @vivmishra ) |
|
/azp run |
|
/azp run aspnetcore-ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run aspnetcore-ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The only failure here is unrelated and is tracked by https://github.com/aspnet/AspNetCore-Internal/issues/3467 |
|
@dotnet/aspnet-build folks, the only failure here is unrelated and I've filed a separate issue to track that down. This PR is ready to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We currently have the Blazor survey link in the Blazor WASM project, but don't have this link in the Blazor Server project template. This results in getting skewed data, which doesn't allow us to make reasonable decisions. We are now enabling this for Blazor Server projects too to cover all the Blazor users.
User Impact
The Index page in the Blazor Serer app will now have a link in the bottom (similar to what is there in the Blazor WASM project template) which will take users to the survey about Blazor.
Regression
No: this is something new which is going to be visible only in the new projects.
Risk
Minimal
Addresses #17433