Pin external dependencies #17437
Merged
Pin external dependencies #17437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiercn
approved these changes
Nov 26, 2019
wtgodbe
approved these changes
Nov 26, 2019
|
I have some ideas to make this process better by piggy-backing off the baseline packages but I didn't get it to work so I'm falling back to just pure pinning of the package versions. I'm seeing some promise in this approach and I'll merge if the artifacts look correct and the build passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussion, we need to pin the dependencies needed by Blazor packages. @javiercn since these are now pinned, you'll need to update it manually when a new extensions package or jsinterop is available.