[Blazor] Pins the SDK version to 3.1 and forces Blazor projects to compile against it #17479
Conversation
…rojects to compile against the latest released framework
javiercn
force-pushed
the
javiercn/pin-sdk-version
branch
from
629b784 to
aba66e7
Compare
| @@ -6,5 +6,8 @@ | |||
| <VersionPrefix>3.1.0</VersionPrefix> | |||
| <PreReleaseVersionLabel>preview4</PreReleaseVersionLabel> | |||
| <DotNetFinalVersionKind /> | |||
| <!-- This property points to the latest released Microsoft.AspNetCore.App version it needs to be updated to | |||
| target the latest patch before a preview release. --> | |||
| <LatestAspNetCoreReferenceVersion>3.1.0</LatestAspNetCoreReferenceVersion> | |||
There was a problem hiding this comment.
Would it make sense to define this like the following?
<LatestAspNetCoreReferenceVersion>$(MicrosoftNETCoreAppRefPackageVersion)</LatestAspNetCoreReferenceVersion>
... or are there cases where this might not match up?
There was a problem hiding this comment.
I'm not sure about it, its one of the follow-ups I intend to do with the build folks next week.
| <Reference Include="Microsoft.Extensions.CommandLineUtils.Sources" /> | ||
| <Reference Include="Microsoft.Extensions.Hosting" /> |
There was a problem hiding this comment.
We'll have to add all these back in master, right? Or do you plan to stop this whole change from flowing to master somehow?
There was a problem hiding this comment.
We will likely have to resolve/revert the conflict at one point and that should be it.
| }, | ||
| "tools": { | ||
| "dotnet": "3.1.100-preview1-014400", | ||
| "dotnet": "3.1.100", |
There was a problem hiding this comment.
Isn't this updated automatically? Is there a risk that your change here will get overwritten by automation?
There was a problem hiding this comment.
I'm not sure about this, but it will come from a PR from maestro and we can decide what to do there.
There was a problem hiding this comment.
This looks like a good change for the blazor-wasm branch.
My only concern is that we'll need to make sense of which parts of this flow into master and take care of reverting various parts of it. @javiercn, will you be able to work this out, perhaps as part of the next milestone? We don't want to leave this too long and become too disconnected from master because the intention is for Blazor WebAssembly to be buildable and usable against 5.0.0 previews in sync with the Blazor WebAssembly 3.1.x previews.
javiercn
force-pushed
the
javiercn/pin-sdk-version
branch
from
c32bfc1 to
dfa4443
Compare
javiercn
requested review from
dougbu,
ryanbrandenburg and
a team
as code owners
…17471) * Update dependencies from https://github.com/dotnet/arcade build 20191127.5 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19577.5 - Microsoft.DotNet.GenAPI - 1.0.0-beta.19577.5 - Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19577.5 * Update dependencies from https://github.com/aspnet/Blazor build 20191127.1 - Microsoft.AspNetCore.Blazor.Mono - 3.1.0-preview4.19577.1 * [Blazor] Fix Blazor.build package (#17463) * Update dependencies from https://github.com/aspnet/Blazor build 20191128.1 - Microsoft.AspNetCore.Blazor.Mono - 3.1.0-preview4.19578.1 * Fix Blazor WebAssembly hosted publishing * [Blazor] Pins the SDK version to 3.1 and forces Blazor projects to compile against it (#17479) * [Blazor] Fixes publish issue with static web assets on hosted scenarios (#17496)
No description provided.