Change Coherent dependency of Extensions packages #17595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area-infrastructure
wtgodbe
approved these changes
Dec 4, 2019
dougbu
reviewed
Dec 5, 2019
| @@ -57,241 +57,241 @@ | |||
| <Uri>https://github.com/aspnet/EntityFrameworkCore</Uri> | |||
| <Sha>e37a6be067ab62da7fe9b33b93faaa90ed829237</Sha> | |||
| </Dependency> | |||
| <Dependency Name="Microsoft.AspNetCore.Analyzer.Testing" Version="5.0.0-alpha1.19602.5" CoherentParentDependency="Microsoft.EntityFrameworkCore"> | |||
| <Dependency Name="Microsoft.AspNetCore.Analyzer.Testing" Version="5.0.0-alpha1.19603.1" CoherentParentDependency="Microsoft.AspNetCore.Tooling"> | |||
There was a problem hiding this comment.
This is completely incorrect as I understand Maestro++ and darc. @mmitche please confirm.
CoherentParentDependency names a package, not a repo. Since there's nothing named Microsoft.AspNetCore.Tooling, you're likely to have cause problems for Maestro++ and certainly aren't keeping things coherent. I suggest CoherentParentDependency="Microsoft.CodeAnalysis.Razor" or CoherentParentDependency="Microsoft.NET.Sdk.Razor"
There was a problem hiding this comment.
@dougbu you're right, I looked over this too quickly. It just so happens that there's a package named Microsoft.EntityFrameworkCore, which we used for the CoherentParentDependency. There is not a package named Microsoft.AspNetCore.Tooling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reaction to dotnet/efcore@12e0263