Handle IIS OnCompleted callbacks later #17756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halter73
reviewed
Dec 10, 2019
Can't you write a regression test that verifies that the client now gets a complete response despite an OnCompleted callback that blocks indefinitely? The bug was that the was an observable side-effect on the client. |
Added. I was worried that would prevent the server from shutting down, but it doesn't. |
halter73
approved these changes
Dec 11, 2019
jkotalik
approved these changes
Dec 11, 2019
Tratcher
added a commit
that referenced
this pull request
May 5, 2020
jkotalik
pushed a commit
that referenced
this pull request
Aug 7, 2020
jkotalik
pushed a commit
that referenced
this pull request
Aug 13, 2020
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#17268 IIS doesn't unblock the end of a response until PostCompletion is called. I've refactored here so that PostCompletion gets called after all things that modify the response but before the OnCompleted callbacks get fired.
I couldn't see how to write an automated test for this since OnCompleted is intentionally not supposed to have observable side-effects on the client.