Skip to content

Remove nameof for log event name #17807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2020
Merged

Remove nameof for log event name #17807

merged 1 commit into from
Jan 16, 2020

Conversation

Kahbazi
Copy link
Member

@Kahbazi Kahbazi commented Dec 12, 2019

No description provided.

@analogrelay analogrelay self-assigned this Jan 8, 2020
analogrelay
analogrelay approved these changes Jan 8, 2020
View reviewed changes
Copy link
Contributor

@analogrelay analogrelay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@analogrelay
Copy link
Contributor

Re-running the builds. Likely just build flakiness :(

@jkotalik
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@ghost
Copy link

ghost commented Jan 14, 2020

Hello @anurse!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@analogrelay
Copy link
Contributor

I'm going to override branch protection and merge this.

  1. It's a trivial nameof fix in master. I doubt there's an issue
  2. It appears we've got a clean build but the GitHub checks haven't been updated properly.

@analogrelay analogrelay merged commit 44e4493 into dotnet:master Jan 16, 2020
@Kahbazi Kahbazi deleted the patch-12 branch January 16, 2020 20:57
@amcasey amcasey added area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@analogrelay analogrelay analogrelay approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

Assignees

@analogrelay analogrelay

Labels
area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Kahbazi @analogrelay @jkotalik @Pilchie @amcasey