Skip to content

Fix SignalR Java tests not running #18114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 8, 2020
Merged

Fix SignalR Java tests not running #18114

merged 2 commits into from
Jan 8, 2020

Conversation

BrennanConroy
Copy link
Member

IDK when it happened, but the Java tests stopped running at some point.

@BrennanConroy BrennanConroy added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 3, 2020
@BrennanConroy BrennanConroy added this to the 5.0.0-preview1 milestone Jan 3, 2020
@BrennanConroy BrennanConroy requested a review from a team January 3, 2020 21:57
@github-actions github-actions bot added the area-signalr Includes: SignalR clients and servers label Jan 3, 2020
@@ -11,6 +11,8 @@

<IsShippingPackage>true</IsShippingPackage>

<IsTestProject>true</IsTestProject>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this project more like a sample?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is the java library we ship, and also the project that we run the tests from.

@@ -1,3 +1,4 @@

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert changes to this file

@BrennanConroy
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@BrennanConroy BrennanConroy merged commit 97a59f1 into master Jan 8, 2020
@BrennanConroy BrennanConroy deleted the brecon/javaT branch January 8, 2020 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework area-signalr Includes: SignalR clients and servers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants