Skip to content

Use ISystemClock for Twitter auth request timestamps #18124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2020
Merged

Use ISystemClock for Twitter auth request timestamps #18124

merged 1 commit into from
Jan 4, 2020

Conversation

martincostello
Copy link
Member

  • Use ISystemClock to generate timestamps for Twitter authentication.
  • Remove custom static field for the epoch.

@martincostello
Use ISystemClock for request timestamps
5f47b01 
Use ISystemClock to generate timestamps for Twitter authentication.
Remove custom static field for the epoch.
@Tratcher Tratcher self-assigned this Jan 4, 2020
@Tratcher Tratcher added the area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer label Jan 4, 2020
@Tratcher Tratcher merged commit c802134 into dotnet:master Jan 4, 2020
@Tratcher
Copy link
Member

Tratcher commented Jan 4, 2020

Thanks

@Tratcher Tratcher added this to the 5.0.0-preview1 milestone Jan 4, 2020
@martincostello martincostello deleted the Twitter-Use-Clock-Abstraction branch January 4, 2020 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher approved these changes

@analogrelay analogrelay Awaiting requested review from analogrelay

Assignees

@Tratcher Tratcher

Labels
area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer
Projects
None yet
Milestone
5.0.0-preview1
Development

Successfully merging this pull request may close these issues.
2 participants
@martincostello @Tratcher