Update branding to 3.0.3 #18217

JunTaoLuo · 2020-01-09T01:20:10Z

https://github.com/aspnet/AspNetCore-Internal/issues/3464

…ositories This pull request updates the following dependencies [marker]: <> (Begin:24caa7fc-346f-47b4-c5c6-08d76fa9c820) ## From https://github.com/aspnet/EntityFrameworkCore - **Build**: 20191208.3 - **Date Produced**: 12/8/2019 4:22 PM - **Commit**: cd16513c90c11170f43057c9af5c75363837a742 - **Branch**: refs/heads/internal/release/3.0 - **Updates**: - **Microsoft.EntityFrameworkCore.Tools** -> 3.0.2-servicing.19608.3 - **Microsoft.EntityFrameworkCore.SqlServer** -> 3.0.2-servicing.19608.3 - **dotnet-ef** -> 3.0.2-servicing.19608.3 - **Microsoft.EntityFrameworkCore** -> 3.0.2-servicing.19608.3 - **Microsoft.EntityFrameworkCore.InMemory** -> 3.0.2-servicing.19608.3 - **Microsoft.EntityFrameworkCore.Relational** -> 3.0.2-servicing.19608.3 - **Microsoft.EntityFrameworkCore.Sqlite** -> 3.0.2-servicing.19608.3 [marker]: <> (End:24caa7fc-346f-47b4-c5c6-08d76fa9c820) [marker]: <> (Begin:Coherency Updates) ## Coherency Updates The following updates ensure that dependencies with a *CoherentParentDependency* attribute were produced in a build used as input to the parent dependency's build. See [Dependency Description Format](https://github.com/dotnet/arcade/blob/master/Documentation/DependencyDescriptionFormat.md#dependency-description-overview) - **System.Drawing.Common** -> 4.6.0 (parent: Microsoft.NETCore.App.Runtime.win-x64) - **Microsoft.NETCore.Platforms** -> 3.0.0 (parent: Microsoft.NETCore.App.Runtime.win-x64) [marker]: <> (End:Coherency Updates)

…ositories This pull request updates the following dependencies [marker]: <> (Begin:84a76f0f-36f1-4cd1-d435-08d76e1d3434) ## From https://dev.azure.com/dnceng/internal/_git/aspnet-AspNetCore-Tooling - **Build**: 20191214.13 - **Date Produced**: 12/15/2019 3:31 AM - **Commit**: 7dfb8241da14b065a0453b969c570a6736f31b54 - **Branch**: refs/heads/internal/release/3.0 - **Updates**: - **Microsoft.NET.Sdk.Razor** -> 3.0.2 - **Microsoft.CodeAnalysis.Razor** -> 3.0.2 - **Microsoft.AspNetCore.Razor.Language** -> 3.0.2 - **Microsoft.AspNetCore.Mvc.Razor.Extensions** -> 3.0.2 [marker]: <> (End:84a76f0f-36f1-4cd1-d435-08d76e1d3434) [marker]: <> (Begin:Coherency Updates) ## Coherency Updates The following updates ensure that dependencies with a *CoherentParentDependency* attribute were produced in a build used as input to the parent dependency's build. See [Dependency Description Format](https://github.com/dotnet/arcade/blob/master/Documentation/DependencyDescriptionFormat.md#dependency-description-overview) - **System.Drawing.Common** -> 4.6.0 (parent: Microsoft.NETCore.App.Runtime.win-x64) - **Microsoft.NETCore.Platforms** -> 3.0.0 (parent: Microsoft.NETCore.App.Runtime.win-x64) [marker]: <> (End:Coherency Updates)

Update dependencies. Somehow the last 3.0 EFCore update got missed.

dougbu

Incomplete w/o downloading the 3.0.2 packages

dougbu · 2020-01-09T05:04:06Z

eng/Baseline.Designer.props

@@ -332,11 +332,11 @@
  </ItemGroup>
  <!-- Package: Microsoft.AspNetCore.DataProtection.EntityFrameworkCore-->
  <PropertyGroup Condition=" '$(PackageId)' == 'Microsoft.AspNetCore.DataProtection.EntityFrameworkCore' ">
-    <BaselinePackageVersion>3.0.0</BaselinePackageVersion>
+    <BaselinePackageVersion>3.0.1</BaselinePackageVersion>


Need more 3.0.2 changes before this is ready to go

JunTaoLuo · 2020-01-14T23:06:02Z

We're going to be blocked on this for a while. We noticed that extensions packages were not pushed, and nuget index still hasn't updated for aspnetcore packages.

dougbu

Once the build succeeds

JunTaoLuo · 2020-01-15T01:27:48Z

Yea I'm waiting until x64/x86 finishes before retrying

JunTaoLuo · 2020-01-15T02:34:38Z

eng/scripts/CodeCheck.ps1

@@ -47,7 +47,12 @@ function LogError {
 try {
    if ($ci) {
        # Install dotnet.exe
-        & $repoRoot/restore.cmd -ci -NoBuildNodeJS -DotNetRuntimeSourceFeed $DotNetRuntimeSourceFeed -DotNetRuntimeSourceFeedKey $DotNetRuntimeSourceFeedKey
+        if ($DotNetRuntimeSourceFeed -or $DotNetRuntimeSourceFeedKey) {


@mmitche I think this was failing since the variables DotNetRuntimeSourceFeed and DotNetRuntimeSourceFeedKey may be empty and will fail when passed to build.ps1. Does this sound right to you?

We should be able to accept both cases.

dougbu · 2020-01-15T02:48:34Z

So far, HubMethodInvokeDoesNotCountTowardsClientTimeout is the one that looks like it'll hold this PR up.

@anurse @jkotalik I see comments about this test in aspnet/AspNetCore-Internal@2181 but they only mention 'release/3.1'. Is it known to be flaky in 'release/3.0' as well?

Basically, can we merge once the current builds complete? Or, should we wait for a Ubuntu retry?

BrennanConroy · 2020-01-15T02:51:52Z

New test thats flaky, you can merge if it's the only failure. I'll look into fixing it

dougbu · 2020-01-15T02:52:47Z

Thanks @BrennanConroy❕

dougbu · 2020-01-15T03:15:39Z

Shoot. Templates tests are also failing. More flakiness? If yes, probably need to retry both legs once the other jobs complete.

BrennanConroy · 2020-01-15T03:54:07Z

Templates failures don't look like flakiness.

Unable to find package Microsoft.AspNetCore.App.Ref with version (= 3.0.2)

JunTaoLuo · 2020-01-15T04:02:04Z

Strange, we specifically didn't build a ref pack in 3.0.2, so I'm curious why it's looking for it.

dougbu · 2020-01-15T06:14:45Z

FYI @BrennanConroy HubMethodInvokeDoesNotCountTowardsClientTimeout failed again after @JunTaoLuo's latest update. See https://dev.azure.com/dnceng/public/_build/results?buildId=483830&view=ms.vss-test-web.build-test-results-tab&runId=15357214&resultId=111836&paneView=debug

And, yes, we'll ignore it if the remaining unmarked tests pass 😺

BrennanConroy and others added 19 commits November 25, 2019 19:37

Merged PR 4502: [SignalR] Wait to complete pipe and cancel long sends

d1f3636

Merge in 'release/3.0' changes

7831644

Merge in 'release/3.0' changes

e533c20

Merge in 'release/3.0' changes

a9ef1f8

Merge in 'release/3.0' changes

fe4d8e2

Merge in 'release/3.0' changes

2233f26

Merge in 'release/3.0' changes

850ab90

Merge in 'release/3.0' changes

b787d9a

Merge in 'release/3.0' changes

1beb7e8

Merge in 'release/3.0' changes

bcc9ca3

Merge in 'release/3.0' changes

f89a66b

Merge in 'release/3.0' changes

8c93562

Merge in 'release/3.0' changes

9e22f6b

Merge in 'release/3.0' changes

2fb8356

Merge in 'release/3.0' changes

995a348

Merged PR 4817: [internal/release/3.0] Stabilize package versions

ded7866

Merged PR 4909: [release/3.0] Update dependencies

561deb0

Update dependencies. Somehow the last 3.0 EFCore update got missed.

JunTaoLuo requested a review from dougbu as a code owner January 9, 2020 01:20

dougbu suggested changes Jan 9, 2020

View reviewed changes

Pilchie added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 9, 2020

Update branding to 3.0.3

8a4204b

Update baseline

a8bb8dd

JunTaoLuo force-pushed the johluo/3.0-feb20 branch from 18dcd3b to a8bb8dd Compare January 15, 2020 00:19

JunTaoLuo requested review from analogrelay, BrennanConroy and halter73 as code owners January 15, 2020 00:19

dougbu approved these changes Jan 15, 2020

View reviewed changes

Fix CodeCheck

15ac53c

JunTaoLuo commented Jan 15, 2020

View reviewed changes

Fixup templates

53b510f

JunTaoLuo requested a review from ryanbrandenburg as a code owner January 15, 2020 05:36

dougbu merged commit f9d58da into release/3.0 Jan 15, 2020

dougbu deleted the johluo/3.0-feb20 branch January 15, 2020 07:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update branding to 3.0.3 #18217

Update branding to 3.0.3 #18217

Uh oh!

JunTaoLuo commented Jan 9, 2020

Uh oh!

dougbu left a comment

Uh oh!

dougbu Jan 9, 2020

Uh oh!

JunTaoLuo commented Jan 14, 2020

Uh oh!

dougbu left a comment

Uh oh!

JunTaoLuo commented Jan 15, 2020

Uh oh!

JunTaoLuo Jan 15, 2020

Uh oh!

mmitche Jan 15, 2020

Uh oh!

dougbu commented Jan 15, 2020

Uh oh!

BrennanConroy commented Jan 15, 2020

Uh oh!

dougbu commented Jan 15, 2020

Uh oh!

dougbu commented Jan 15, 2020

Uh oh!

BrennanConroy commented Jan 15, 2020

Uh oh!

JunTaoLuo commented Jan 15, 2020

Uh oh!

dougbu commented Jan 15, 2020

Uh oh!

Uh oh!

Update branding to 3.0.3 #18217

Update branding to 3.0.3 #18217

Uh oh!

Conversation

JunTaoLuo commented Jan 9, 2020

Uh oh!

dougbu left a comment

Choose a reason for hiding this comment

Uh oh!

dougbu Jan 9, 2020

Choose a reason for hiding this comment

Uh oh!

JunTaoLuo commented Jan 14, 2020

Uh oh!

dougbu left a comment

Choose a reason for hiding this comment

Uh oh!

JunTaoLuo commented Jan 15, 2020

Uh oh!

JunTaoLuo Jan 15, 2020

Choose a reason for hiding this comment

Uh oh!

mmitche Jan 15, 2020

Choose a reason for hiding this comment

Uh oh!

dougbu commented Jan 15, 2020

Uh oh!

BrennanConroy commented Jan 15, 2020

Uh oh!

dougbu commented Jan 15, 2020

Uh oh!

dougbu commented Jan 15, 2020

Uh oh!

BrennanConroy commented Jan 15, 2020

Uh oh!

JunTaoLuo commented Jan 15, 2020

Uh oh!

dougbu commented Jan 15, 2020

Uh oh!

Uh oh!