Implement HttpRequestStreamReader.ReadToEndAsync #18232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaslevesque
requested review from
analogrelay,
jkotalik and
Tratcher
as code owners
thomaslevesque
force-pushed
the
readtoendasync
branch
from
089f44b to
439eaec
Compare
thomaslevesque
changed the title
Tratcher
reviewed
Jan 9, 2020
|
The reference assemblies need to be updated. https://github.com/dotnet/aspnetcore/blob/master/docs/ReferenceAssemblies.md |
@Tratcher done |
thomaslevesque
force-pushed
the
readtoendasync
branch
from
8f49e3f to
f295ee2
Compare
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
I opened dotnet/runtime#31763 to see if we cannot get this + ReadLineAsync() + ReadBlockAsync() implemented without blocking in the TextReader base type. |
jkotalik
reviewed
Feb 9, 2020
jkotalik
reviewed
Feb 9, 2020
|
@jkotalik let's just get this in :). |
|
@anurse any updates on this? |
|
@thomaslevesque there were a few merge conflicts with #18802, would you mind fixing those? |
jkotalik
approved these changes
Apr 13, 2020
thomaslevesque
force-pushed
the
readtoendasync
branch
from
f295ee2 to
7f7b40c
Compare
|
@jkotalik I rebased my changes onto master and fixed the conflicts |
jkotalik
approved these changes
Apr 14, 2020
|
Thanks! |
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes (Less than 80 chars)
ReadToEndAsynconHttpRequestStreamReaderAddresses #13834
The implementation is based on
StreamReader.ReadToEndAsync, adapted to work withHttpRequestStreamReader.