Skip to content

Contributing: Fixed some typos #18331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/scripts/StartDumpCollectionForHangingBuilds.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ Write-Output "Watching processes $($CandidateProcessNames -join ', ')";
# This script registers as a scheduled job. This scheduled job executes after $WakeTime.
# When the scheduled job executes, it runs procdump on all alive processes whose name matches $CandidateProcessNames.
# The dumps are placed in $ProcDumpOutputPath
# If the build completes sucessfully in less than $WakeTime, a final step unregisters the job.
# If the build completes successfully in less than $WakeTime, a final step unregisters the job.

# Create a unique identifier for the job name
$JobName = "CaptureDumps" + (New-Guid).ToString("N");
Expand Down
2 changes: 1 addition & 1 deletion src/Components/Server/src/Circuits/RemoteRenderer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ internal class RemoteRenderer : Microsoft.AspNetCore.Components.RenderTree.Rende
private bool _disposing = false;

/// <summary>
/// Notifies when a rendering exception occured.
/// Notifies when a rendering exception occurred.
/// </summary>
public event EventHandler<Exception> UnhandledException;

Expand Down
2 changes: 1 addition & 1 deletion src/Components/Server/src/ComponentHub.cs
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ private static class Log
LoggerMessage.Define<CircuitId, string, string>(LogLevel.Debug, new EventId(7, "CreatedCircuit"), "Created circuit '{CircuitId}' with secret '{CircuitIdSecret}' for '{ConnectionId}'");

private static readonly Action<ILogger, string, Exception> _invalidCircuitId =
LoggerMessage.Define<string>(LogLevel.Debug, new EventId(8, "InvalidCircuitId"), "ConnectAsync recieved an invalid circuit id '{CircuitIdSecret}'");
LoggerMessage.Define<string>(LogLevel.Debug, new EventId(8, "InvalidCircuitId"), "ConnectAsync received an invalid circuit id '{CircuitIdSecret}'");

public static void ReceivedConfirmationForBatch(ILogger logger, long batchId) => _receivedConfirmationForBatch(logger, batchId, null);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ public IList<Topping> GetToppings()
},
new Topping()
{
Name = "Fresh tomatos",
Name = "Fresh tomatoes",
Price = 1.50m,
},
new Topping()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ public void MoveProperty_ShouldFail()
}

[Fact]
public void TestStringProperty_IsSucessful()
public void TestStringProperty_IsSuccessful()
{
// Arrange
var targetObject = new
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ public void ShouldNotReplaceProperty_WithDifferentCase()
}

[Fact]
public void TestIntegerProperty_IsSucessful()
public void TestIntegerProperty_IsSuccessful()
{
// Arrange
dynamic targetObject = new ExpandoObject();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ public void RequestEnd(HttpContext httpContext, Exception exception, HostingAppl
var startTimestamp = context.StartTimestamp;
long currentTimestamp = 0;

// If startTimestamp was 0, then Information logging wasn't enabled at for this request (and calcuated time will be wildly wrong)
// If startTimestamp was 0, then Information logging wasn't enabled at for this request (and calculated time will be wildly wrong)
// Is used as proxy to reduce calls to virtual: _logger.IsEnabled(LogLevel.Information)
if (startTimestamp != 0)
{
Expand All @@ -109,7 +109,7 @@ public void RequestEnd(HttpContext httpContext, Exception exception, HostingAppl

if (exception == null)
{
// No exception was thrown, request was sucessful
// No exception was thrown, request was successful
if (_diagnosticListener.IsEnabled(DeprecatedDiagnosticsEndRequestKey))
{
// Diagnostics is enabled for EndRequest, but it may not be for BeginRequest
Expand Down Expand Up @@ -317,7 +317,7 @@ private Activity StartActivity(Activity activity, HttpContext httpContext)
private void StopActivity(Activity activity, HttpContext httpContext)
{
// Stop sets the end time if it was unset, but we want it set before we issue the write
// so we do it now.
// so we do it now.
if (activity.Duration == TimeSpan.Zero)
{
activity.SetEndTime(DateTime.UtcNow);
Expand Down
4 changes: 2 additions & 2 deletions src/Http/Routing/src/DefaultLinkGenerator.cs
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ public static class EventIds
LogLevel.Debug,
EventIds.TemplateFailedExpansion,
"Failed to process the template {Template} for {Endpoint}. " +
"The failure occured while expanding the template with values {Values} " +
"The failure occurred while expanding the template with values {Values} " +
"This is usually due to a missing or empty value in a complex segment");

private static readonly Action<ILogger, IEnumerable<string>, string, Exception> _linkGenerationSucceeded = LoggerMessage.Define<IEnumerable<string>, string>(
Expand Down Expand Up @@ -442,7 +442,7 @@ public static void TemplateFailedExpansion(ILogger logger, RouteEndpoint endpoin
}
}

public static void LinkGenerationSucceeded(ILogger logger, IEnumerable<Endpoint> endpoints, string uri)
public static void LinkGenerationSucceeded(ILogger logger, IEnumerable<Endpoint> endpoints, string uri)
{
// Checking level again to avoid allocation on the common path
if (logger.IsEnabled(LogLevel.Debug))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public override Task Match_SingleParameter()
{
return Task.CompletedTask;
}

// Route values not supported
[Fact]
public override Task Match_SingleParameter_TrailingSlash()
Expand All @@ -25,7 +25,7 @@ public override Task Match_SingleParameter_TrailingSlash()

// Route values not supported
[Fact]
public override Task Match_SingleParameter_WierdNames()
public override Task Match_SingleParameter_WeirdNames()
{
return Task.CompletedTask;
}
Expand All @@ -35,7 +35,7 @@ public override Task Match_SingleParameter_WierdNames()
[InlineData(null, null, null, null)]
public override Task Match_MultipleParameters(string template, string path, string[] keys, string[] values)
{
GC.KeepAlive(new object [] { template, path, keys, values });
GC.KeepAlive(new object[] { template, path, keys, values });
return Task.CompletedTask;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ public virtual async Task Match_CatchAllParameter(string template, string path,

// Historically catchall segments don't match an empty segment, but only if it's
// the first one. So `/a/b//` would match, but `/a//` would not. This is pretty
// wierd and inconsistent with the intent of using a catch all. The DfaMatcher
// weird and inconsistent with the intent of using a catch all. The DfaMatcher
// fixes this issue.
[Theory]
[InlineData("/{a}/{*b=b}", "/a///", new[] { "a", "b", }, new[] { "a", "//" })]
Expand Down Expand Up @@ -313,7 +313,7 @@ public virtual async Task NotMatch_OptionalSeparator(string template, string pat
[InlineData("(Controller).mvc", "/(Controller).mvc", new string[] { }, new string[] { })]
[InlineData("Controller.mvc/ ", "/Controller.mvc/ ", new string[] { }, new string[] { })]
[InlineData("Controller.mvc ", "/Controller.mvc ", new string[] { }, new string[] { })]
public virtual async Task Match_WierdCharacterCases(string template, string path, string[] keys, string[] values)
public virtual async Task Match_WeirdCharacterCases(string template, string path, string[] keys, string[] values)
{
// Arrange
var (matcher, endpoint) = CreateMatcher(template);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ public virtual async Task Match_SingleLiteralSegment_Unicode(string template, st
MatcherAssert.AssertMatch(httpContext, endpoint);
}

// Matchers should operate on the decoded representation - a matcher that calls
// Matchers should operate on the decoded representation - a matcher that calls
// `httpContext.Request.Path.ToString()` will break this test.
[Theory]
[InlineData("/S%mple", "/S%mple")]
Expand Down Expand Up @@ -239,7 +239,7 @@ public virtual async Task Match_SingleParameter_TrailingSlash()
}

[Fact]
public virtual async Task Match_SingleParameter_WierdNames()
public virtual async Task Match_SingleParameter_WeirdNames()
{
// Arrange
var (matcher, endpoint) = CreateMatcher("/foo/{ }/{.!$%}/{dynamic.data}");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ public void Parse_ComplexSegment_OptionalParameterFollowingPeriod_ThreeParameter
}

[Fact]
public void Parse_ComplexSegment_ThreeParametersSeperatedByPeriod()
public void Parse_ComplexSegment_ThreeParametersSeparatedByPeriod()
{
// Arrange
var template = "{p1}.{p2}.{p3}";
Expand Down Expand Up @@ -352,7 +352,7 @@ public void Parse_RegularExpressions(string template, string constraint)
[Theory]
[InlineData(@"{p1:regex(^\d{{3}}-\d{{3}}-\d{{4}}}$)}")] // extra }
[InlineData(@"{p1:regex(^\d{{3}}-\d{{3}}-\d{{4}}$)}}")] // extra } at the end
[InlineData(@"{{p1:regex(^\d{{3}}-\d{{3}}-\d{{4}}$)}")] // extra { at the begining
[InlineData(@"{{p1:regex(^\d{{3}}-\d{{3}}-\d{{4}}$)}")] // extra { at the beginning
[InlineData(@"{p1:regex(([}])\w+}")] // Not escaped }
[InlineData(@"{p1:regex(^\d{{3}}-\d{{3}}-\d{{4}$)}")] // Not escaped }
[InlineData(@"{p1:regex(abc)")]
Expand Down Expand Up @@ -400,7 +400,7 @@ public void Parse_ComplexSegment_OptionalParameter_NotTheLastPart(
[InlineData("..{p2?}", "..")]
[InlineData("{p1}.abc.{p2?}", ".abc.")]
[InlineData("{p1}{p2?}", "{p1}")]
public void Parse_ComplexSegment_OptionalParametersSeperatedByPeriod_Invalid(string template, string parameter)
public void Parse_ComplexSegment_OptionalParametersSeparatedByPeriod_Invalid(string template, string parameter)
{
// Act and Assert
ExceptionAssert.Throws<RoutePatternException>(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ public void Parse_ComplexSegment_OptionalParameterFollowingPeriod_ThreeParameter
}

[Fact]
public void Parse_ComplexSegment_ThreeParametersSeperatedByPeriod()
public void Parse_ComplexSegment_ThreeParametersSeparatedByPeriod()
{
// Arrange
var template = "{p1}.{p2}.{p3}";
Expand Down Expand Up @@ -498,7 +498,7 @@ public void Parse_RegularExpressions(string template, string constraint)
[Theory]
[InlineData(@"{p1:regex(^\d{{3}}-\d{{3}}-\d{{4}}}$)}")] // extra }
[InlineData(@"{p1:regex(^\d{{3}}-\d{{3}}-\d{{4}}$)}}")] // extra } at the end
[InlineData(@"{{p1:regex(^\d{{3}}-\d{{3}}-\d{{4}}$)}")] // extra { at the begining
[InlineData(@"{{p1:regex(^\d{{3}}-\d{{3}}-\d{{4}}$)}")] // extra { at the beginning
[InlineData(@"{p1:regex(([}])\w+}")] // Not escaped }
[InlineData(@"{p1:regex(^\d{{3}}-\d{{3}}-\d{{4}$)}")] // Not escaped }
[InlineData(@"{p1:regex(abc)")]
Expand Down Expand Up @@ -550,7 +550,7 @@ public void Parse_ComplexSegment_OptionalParameter_NotTheLastPart(
[InlineData("{p1}.abc.{p2?}", ".abc.")]
[InlineData("{p1}{p2?}", "{p1}")]
[ReplaceCulture]
public void Parse_ComplexSegment_OptionalParametersSeperatedByPeriod_Invalid(string template, string parameter)
public void Parse_ComplexSegment_OptionalParametersSeparatedByPeriod_Invalid(string template, string parameter)
{
// Act and Assert
ExceptionAssert.Throws<ArgumentException>(
Expand Down
4 changes: 2 additions & 2 deletions src/Http/WebUtilities/src/FormPipeReader.cs
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ private void ParseFormValuesFast(ReadOnlySpan<byte> span,
// If we're not in the final block, then consume nothing
if (!isFinalBlock)
{
// Don't buffer indefinately
// Don't buffer indefinitely
if ((uint)span.Length > (uint)KeyLengthLimit + (uint)ValueLengthLimit)
{
ThrowKeyOrValueTooLargeException();
Expand Down Expand Up @@ -236,7 +236,7 @@ private void ParseValuesSlow(
{
if (!isFinalBlock)
{
// Don't buffer indefinately
// Don't buffer indefinitely
if ((uint)(sequenceReader.Consumed - consumedBytes) > (uint)KeyLengthLimit + (uint)ValueLengthLimit)
{
ThrowKeyOrValueTooLargeException();
Expand Down
2 changes: 1 addition & 1 deletion src/Http/WebUtilities/src/QueryHelpers.cs
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ private static string AddQueryString(
var anchorIndex = uri.IndexOf('#');
var uriToBeAppended = uri;
var anchorText = "";
// If there is an anchor, then the query string must be inserted before its first occurence.
// If there is an anchor, then the query string must be inserted before its first occurrence.
if (anchorIndex != -1)
{
anchorText = uri.Substring(anchorIndex);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@ HASH_TABLE<_Record,_Key>::InsertRecord(
)
/*++
This method inserts a node for this record and also empty nodes for paths
in the heirarchy leading upto this path
in the hierarchy leading upto this path

The insert is done under only a read-lock - this is possible by keeping
the hashes in a bucket in increasing order and using interlocked operations
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ extern "C" {
#define HTTP_INITIALIZE_SERVER 0x00000001
#define HTTP_INITIALIZE_CONFIG 0x00000002

#if _WIN32_WINNT <= 0x0501
#if _WIN32_WINNT <= 0x0501
#define BUILD_IIS_FOR_XP 1
#endif

Expand Down Expand Up @@ -582,7 +582,7 @@ typedef enum _HTTP_LOGGING_ROLLOVER_TYPE
// log file rollovers happen by GMT time.
//
// HTTP_LOGGING_FLAG_USE_UTF8_CONVERSION - When set the unicode fields
// will be converted to UTF8 multibytes when writting to the log
// will be converted to UTF8 multibytes when writing to the log
// files. When this flag is not present, the local code page
// conversion happens.
//
Expand Down Expand Up @@ -1736,10 +1736,10 @@ typedef enum _HTTP_RESPONSE_INFO_TYPE
HttpResponseInfoTypeMultipleKnownHeaders,
HttpResponseInfoTypeAuthenticationProperty,
HttpResponseInfoTypeQoSProperty

#if _WIN32_WINNT >= _WIN32_WINNT_WIN7 || BUILD_IIS_FOR_XP
,HttpResponseInfoTypeChannelBind
#endif
#endif

} HTTP_RESPONSE_INFO_TYPE, PHTTP_RESPONSE_INFO_TYPE;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ class PER_CPU
);

//
// Pointer to the begining of the inlined array.
// Pointer to the beginning of the inlined array.
//
PVOID m_pVariables;
SIZE_T m_Alignment;
Expand All @@ -101,7 +101,7 @@ PER_CPU<T>::Create(
DWORD ObjectCacheLineSize = 0;
DWORD NumberOfProcessors = 0;
PER_CPU<T> * pInstance = NULL;

hr = GetProcessorInformation(&CacheLineSize,
&NumberOfProcessors);
if (FAILED(hr))
Expand Down Expand Up @@ -140,7 +140,7 @@ PER_CPU<T>::Create(
// The array start in the 2nd cache line.
//
pInstance->m_pVariables = reinterpret_cast<PBYTE>(pInstance) + CacheLineSize;

//
// Pass a disposer for disposing initialized items in case of failure.
//
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,7 @@ TREE_HASH_TABLE<_Record>::InsertRecord(
)
/*++
This method inserts a node for this record and also empty nodes for paths
in the heirarchy leading upto this path
in the hierarchy leading upto this path

The insert is done under only a read-lock - this is possible by keeping
the hashes in a bucket in increasing order and using interlocked operations
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1637,7 +1637,7 @@ Routine Description:

Return Value:

The index for the first character occurence in the string.
The index for the first character occurrence in the string.

-1 if not found.

Expand Down Expand Up @@ -1684,7 +1684,7 @@ Routine Description:

Return Value:

The index for the first character occurence in the string.
The index for the first character occurrence in the string.

-1 if not found.

Expand Down Expand Up @@ -1733,7 +1733,7 @@ Routine Description:

Return Value:

The index for the last character occurence in the string.
The index for the last character occurrence in the string.

-1 if not found.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1083,7 +1083,7 @@ Routine Description:

Return Value:

The index for the first character occurence in the string.
The index for the first character occurrence in the string.

-1 if not found.

Expand Down Expand Up @@ -1130,7 +1130,7 @@ Routine Description:

Return Value:

The index for the first character occurence in the string.
The index for the first character occurrence in the string.

-1 if not found.

Expand Down Expand Up @@ -1179,7 +1179,7 @@ Routine Description:

Return Value:

The index for the last character occurence in the string.
The index for the last character occurrence in the string.

-1 if not found.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ enum SETUP_LOG_SEVERITY
//consider using an IIS prefix for Msi* methods - they conflict with MSI apis

//
// Initalize logging once at begining of CA
// Initialize logging once at beginning of CA
//

VOID
Expand All @@ -31,7 +31,7 @@ IISLogInitialize(

//
// Close logging at end / exit of CA
//
//

VOID
IISLogClose(
Expand All @@ -40,7 +40,7 @@ IISLogClose(

//
// Writes a message to msi log file
//
//
VOID
IISLogWrite(
IN SETUP_LOG_SEVERITY setupLogSeverity,
Expand Down
Loading