Skip to content

Use reference assemblies when compiling Razor views #18395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 17, 2020

Conversation

pranavkm
Copy link
Contributor

Fixes #18323

@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 16, 2020
@JunTaoLuo
Copy link
Contributor

Please fill out the servicing template and wait for shiproom approval. We want to take this in the 3.1 patch.

@JunTaoLuo JunTaoLuo added this to the 3.1.2 milestone Jan 16, 2020
Copy link
Contributor

@JunTaoLuo JunTaoLuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense to me

@wtgodbe
Copy link
Member

wtgodbe commented Jan 16, 2020

@pranavkm looks like this broke other projects, maybe have the target conditionally only run for projects that set some property (specifically the inner builds of identity.ui)?

@dougbu
Copy link
Contributor

dougbu commented Jan 16, 2020

Once we get the Right Thing:tm: in this PR (perhaps, as @wtgodbe suggested, by narrowing when it's applied) should we instead take this as a tell-mode change @Pilchie

@pranavkm
Copy link
Contributor Author

We verified that this also affects all the other UI projects (Azure.UI etc). I'm going to play around with this to see what's causing the build failure.

@wtgodbe
Copy link
Member

wtgodbe commented Jan 17, 2020

I think this should be fine for tell mode - it's treating the same symptom as John's multi-target PR, which was approved, and that arguably could've been infra tell mode as well. @Pilchie thoughts?

@@ -2,6 +2,7 @@

<PropertyGroup>
<TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework>
<CompileUsingReferenceAssemblies>false</CompileUsingReferenceAssemblies>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one project had an intersection of Components from the shared fx and Components as a package via Blazor. Using the ref assembly to compile here caused version mismatch during compile. This seems to be the only project that's affected by the workaround.

@Pilchie
Copy link
Member

Pilchie commented Jan 17, 2020

Let’s use tell mode for this one. I’d rather get the build unblocked ASAP.

@wtgodbe wtgodbe added the tell-mode Indicates a PR which is being merged during tell-mode label Jan 17, 2020
@rynowak
Copy link
Member

rynowak commented Jan 17, 2020

@pranavkm - do we need to port this workaround to AspNetCore-Tooling?

@wtgodbe wtgodbe merged commit cd518e9 into release/3.1 Jan 17, 2020
@wtgodbe wtgodbe deleted the prkrishn/razor-sdk-ref-assembly branch January 17, 2020 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants