-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Use reference assemblies when compiling Razor views #18395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Please fill out the servicing template and wait for shiproom approval. We want to take this in the 3.1 patch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes make sense to me
@pranavkm looks like this broke other projects, maybe have the target conditionally only run for projects that set some property (specifically the inner builds of identity.ui)? |
We verified that this also affects all the other UI projects (Azure.UI etc). I'm going to play around with this to see what's causing the build failure. |
I think this should be fine for tell mode - it's treating the same symptom as John's multi-target PR, which was approved, and that arguably could've been infra tell mode as well. @Pilchie thoughts? |
@@ -2,6 +2,7 @@ | |||
|
|||
<PropertyGroup> | |||
<TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> | |||
<CompileUsingReferenceAssemblies>false</CompileUsingReferenceAssemblies> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one project had an intersection of Components from the shared fx and Components as a package via Blazor. Using the ref assembly to compile here caused version mismatch during compile. This seems to be the only project that's affected by the workaround.
Let’s use tell mode for this one. I’d rather get the build unblocked ASAP. |
@pranavkm - do we need to port this workaround to AspNetCore-Tooling? |
Fixes #18323