Update names and descriptions for benchmarks #18430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
pranavkm
commented
Jan 17, 2020
| @@ -16,29 +16,59 @@ group('JSON handling', () => { | |||
| teardown(() => app.dispose()); | |||
|
|
|||
| benchmark('Serialize 1kb', () => | |||
| benchmarkJson(app, '#serialize-small', '#serialized-length', 935)); | |||
| benchmarkJson(app, '#serialize-small', '#serialized-length', 935), { | |||
There was a problem hiding this comment.
@SteveSandersonMS prior to this change, we were using the value of the name argument (in this case 'Serialize 1kb') as the names recorded by the benchmarking infrastructure. @sebastienros suggested we use less prosaic text and follow the pattern that the rest of the infrastructure uses. I took what was admittedly the easiest way to tack on additional content to a benchmark.
I'm happy with this change as is given that it's ultimately test infrastructure, but I'm open to changes if you feel there's a better way to approach this.
There was a problem hiding this comment.
This is the content we ultimately want to produce: https://gist.github.com/pranavkm/387f83d25600b4d30f7bfc52010227e3
sebastienros
approved these changes
Jan 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.