Skip to content

Resolve Bcl.AsyncInterfaces from NuGet #18606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2020
Merged

Resolve Bcl.AsyncInterfaces from NuGet #18606

merged 1 commit into from
Jan 28, 2020

Conversation

BrennanConroy
Copy link
Member

Fixes #18603 🤞

@BrennanConroy BrennanConroy added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 27, 2020
@BrennanConroy BrennanConroy added this to the 5.0.0-preview1 milestone Jan 27, 2020
@BrennanConroy BrennanConroy marked this pull request as ready for review January 27, 2020 23:16
@BrennanConroy BrennanConroy requested a review from dougbu as a code owner January 27, 2020 23:16
dougbu
dougbu approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Should we be doing this in all branches where we use the package? (@anurse❔)

@BrennanConroy BrennanConroy merged commit 2481862 into master Jan 28, 2020
@BrennanConroy BrennanConroy deleted the brecon/pin branch January 28, 2020 00:01
@analogrelay
Copy link
Contributor

Should we be doing this in all branches where we use the package

I don't think so, unless it's also pinned there. The issue is that this package is not expected to ship further versions in 5.0. However, in 3.0/3.1 it may be serviced and we should continue to use dependency flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbu dougbu dougbu approved these changes

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
5.0.0-preview1
Development

Successfully merging this pull request may close these issues.

Unpin Microsoft.Bcl.AsyncInterfaces dependency
3 participants
@BrennanConroy @analogrelay @dougbu