Use reference equality to compare model instances in EditContext (#1872) #18649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * Use reference equality to compare model instances in EditContext Fixes #18069
ghost
added
the
mkArtakMSFT
added
the
Servicing-consider
SteveSandersonMS
approved these changes
Jan 31, 2020
Pilchie
added
Servicing-approved
This was referenced Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18069
Description
EditContext uses FieldIdentifiers for lookups. The equality and hashcode for
FieldIdentiferattempts to compare instances of an application model, but uses the model's virtualEqualsandGetHashCodemethods. If a model overrides these methods, lookups will fail and you get incorrect validation results. This change uses the non-virtualized methods to compare model instances.Customer impact
Models overriding Equals or GetHashCode cannot be used with a Blazor (server) application.
Regression
No. This behavior has been present since Blazor shipped in 3.0.
Risk
Low. There's a small chance that users may have inadvertently relied on the incorrect behavior and built their application around it. However, we don't commonly see the pattern of users overriding these methods. In the original user reported issue, these methods were code-gen from GRPC proto files.