-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Use non-stable versioning in blazor-wasm #18894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Will resolve the last bullet point of https://github.com/dotnet/aspnetcore-internal/issues/3417 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small cleanup…
@wtgodbe how this impacts the actual packages? Will we need to do anything special, when we will be publishing those? |
Whoops, that was a typo. I meant To write "Marks packages as non-stable". The packages are still marked as shipping packages - you shouldn't have to do anything special for publishing. |
Any other concerns @mkArtakMSFT @pranavkm @javiercn @SteveSandersonMS? If not I'll merge this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @wtgodbe.
Please share the feed where the packages will now be published, as soon as this merges.
Packages will be published to https://dev.azure.com/dnceng/public/_packaging?_a=feed&feed=dotnet3.1-blazor |
Supercedes #18280
Marks packages as non-stable in the
blazor-wasm
branch. With this, packages will all be published to the https://dev.azure.com/dnceng/public/_packaging?_a=feed&feed=dotnet3.1-blazor feed, rather than being published to unique feeds per-build. I also set the global repo version to 3.2.0-preview2, rather than doing it only for the blazor packages.@pranavkm @mkArtakMSFT @javiercn @JunTaoLuo @dougbu PTAL
Validated with internal build: https://dev.azure.com/dnceng/internal/_build/results?buildId=512337
Worth noting - all the Blazor projects are building against Implementation assemblies. The only Blazor project that produces a Ref assembly is
Microsoft.AspNetCore.Blazor
, which isn't referenced by anything. All the other references get resolved to either ProjectReferences to Blazor projects without ref assemblies, or to PackageReferences, which resolve implementation assemblies. All projects we're building here get AssemblyVersion3.2.0.0
, and references generally are to version3.1.2.0