Skip to content

Use non-stable versioning in blazor-wasm #18894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 10, 2020
Merged

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Feb 7, 2020

Supercedes #18280

Marks packages as non-stable in the blazor-wasm branch. With this, packages will all be published to the https://dev.azure.com/dnceng/public/_packaging?_a=feed&feed=dotnet3.1-blazor feed, rather than being published to unique feeds per-build. I also set the global repo version to 3.2.0-preview2, rather than doing it only for the blazor packages.

@pranavkm @mkArtakMSFT @javiercn @JunTaoLuo @dougbu PTAL

Validated with internal build: https://dev.azure.com/dnceng/internal/_build/results?buildId=512337

Worth noting - all the Blazor projects are building against Implementation assemblies. The only Blazor project that produces a Ref assembly is Microsoft.AspNetCore.Blazor, which isn't referenced by anything. All the other references get resolved to either ProjectReferences to Blazor projects without ref assemblies, or to PackageReferences, which resolve implementation assemblies. All projects we're building here get AssemblyVersion 3.2.0.0, and references generally are to version 3.1.2.0

@wtgodbe
Copy link
Member Author

wtgodbe commented Feb 7, 2020

Will resolve the last bullet point of https://github.com/dotnet/aspnetcore-internal/issues/3417

Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small cleanup…

@mkArtakMSFT
Copy link
Contributor

Marks packages as non-shipping in the blazor-wasm branch.

@wtgodbe how this impacts the actual packages? Will we need to do anything special, when we will be publishing those?

@Pilchie Pilchie added the area-blazor Includes: Blazor, Razor Components label Feb 10, 2020
@wtgodbe
Copy link
Member Author

wtgodbe commented Feb 10, 2020

@wtgodbe how this impacts the actual packages? Will we need to do anything special, when we will be publishing those?

Whoops, that was a typo. I meant To write "Marks packages as non-stable". The packages are still marked as shipping packages - you shouldn't have to do anything special for publishing.

@wtgodbe
Copy link
Member Author

wtgodbe commented Feb 10, 2020

Any other concerns @mkArtakMSFT @pranavkm @javiercn @SteveSandersonMS? If not I'll merge this

Copy link
Contributor

@mkArtakMSFT mkArtakMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wtgodbe.
Please share the feed where the packages will now be published, as soon as this merges.

@wtgodbe wtgodbe merged commit cae6a9c into blazor-wasm Feb 10, 2020
@wtgodbe wtgodbe deleted the wtgodbe/NonStablev2 branch February 10, 2020 22:05
@wtgodbe
Copy link
Member Author

wtgodbe commented Feb 10, 2020

Packages will be published to https://dev.azure.com/dnceng/public/_packaging?_a=feed&feed=dotnet3.1-blazor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants