Skip to content

Update launchSettings.json for BlazorWASM #19136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 19, 2020
Merged

Update launchSettings.json for BlazorWASM #19136

merged 2 commits into from
Feb 19, 2020

Conversation

mkArtakMSFT
Copy link
Contributor

@mkArtakMSFT mkArtakMSFT commented Feb 19, 2020 •
edited
Loading

Addresses #18604 #18982

@mkArtakMSFT mkArtakMSFT added the area-blazor Includes: Blazor, Razor Components label Feb 19, 2020
@mkArtakMSFT mkArtakMSFT added this to the blazor-wasm-3.2-preview2 milestone Feb 19, 2020
@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Feb 19, 2020
@SteveSandersonMS SteveSandersonMS self-requested a review February 19, 2020 11:15
SteveSandersonMS
SteveSandersonMS approved these changes Feb 19, 2020
View reviewed changes
Copy link
Member

@SteveSandersonMS SteveSandersonMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just need to remove the useWebAssemblyDebugging lines as mentioned in comments. Thanks!

@SteveSandersonMS SteveSandersonMS mentioned this pull request Feb 19, 2020
Closed
This was linked to issues Feb 19, 2020
Add debugger specific setting to the Blazor project templates #18982
Closed
Standalone Blazor template missing default launch profile content #18604
Closed
@mkArtakMSFT mkArtakMSFT merged commit 6342a81 into blazor-wasm Feb 19, 2020
@mkArtakMSFT mkArtakMSFT deleted the mkArtakMSFT/wasmLaunchSettings branch February 19, 2020 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveSandersonMS SteveSandersonMS SteveSandersonMS approved these changes

@ajaybhargavb ajaybhargavb Awaiting requested review from ajaybhargavb

Assignees
No one assigned
Labels
area-blazor Includes: Blazor, Razor Components area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Milestone
blazor-wasm-3.2-preview2
Development

Successfully merging this pull request may close these issues.

Add debugger specific setting to the Blazor project templates Standalone Blazor template missing default launch profile content
2 participants
@mkArtakMSFT @SteveSandersonMS