Fix watch tests again #19155
Merged
Fix watch tests again #19155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrennanConroy
added
the
area-commandlinetools
analogrelay
reviewed
Feb 19, 2020
| set helixQueue=%5 | ||
| set arch=%6 | ||
| set quarantined=%7 | ||
| REM Use '$' as a variable name prefix to avoid MSBuild variable collisions with these variables |
JunTaoLuo
approved these changes
Feb 20, 2020
BrennanConroy
force-pushed
the
brecon/watchAgain
branch
from
4431a44 to
9e96f47
Compare
BrennanConroy
commented
Feb 20, 2020
| @@ -104,12 +104,15 @@ public void Start(IEnumerable<string> arguments, [CallerMemberName] string name | |||
| WorkingDirectory = SourceDirectory, | |||
| EnvironmentVariables = | |||
| { | |||
| ["DOTNET_CLI_CONTEXT_VERBOSE"] = bool.TrueString, | |||
There was a problem hiding this comment.
FYI @JunTaoLuo, made this change after you approved. It fixes some flakiness with the tests due to dotnet/sdk#10688
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing most of the tests was easy, but finding the
targetFrameworkIdentifiercollision was super not fun...And this time I'll double check the helix test run before merging 😄