Change MapBlazorWebAssemblyApplication to UseBlazorFrameworkFiles #19198

javiercn · 2020-02-20T15:38:29Z

We discovered some issues with the interactions between static files and endpoint routing and we need to re-assess the design.
In the mean time, we go back to MapBlazorFrameworkFiles that only handles _framework files

rynowak · 2020-02-20T17:10:53Z

What are the strange interactions?

javiercn · 2020-02-20T17:59:10Z

@rynowak Ordering issues.

I plan to talk to you about them and see if we can come up with a solution together. We just don't have time to do something better for preview2.

src/Components/WebAssembly/Server/src/ComponentsWebAssemblyApplicationBuilderExtensions.cs

SteveSandersonMS · 2020-02-21T09:26:11Z

src/Components/WebAssembly/Server/src/ComponentsWebAssemblyApplicationBuilderExtensions.cs

            {
-                var endpoint = ctx.GetEndpoint();
-                try
+                subBuilder.Use(async (ctx, next) =>


Out of interest, would an alternative working implementation have been to configure the "on prepare response" callback for options and put the header controls in there, then just have subBuilder.UseStaticFiles(options) without the extra bit of middleware?

I'm not saying that's better. Just want to understand the options.

I just did the most straightforward transformation from what we had before, using OnPrepareResponse would have also worked.

I think the difference you'd seen in behavior here is that OnPrepareResponse would handle the cases where the file was found - this will add a header for a 404.

Yeah, I think you are right, not a big deal since I plan to work on this for preview 3 and a 404 can’t be cached anyways?

Thanks Steve! Co-Authored-By: Steve Sanderson <[email protected]>

src/Components/WebAssembly/Server/src/ComponentsWebAssemblyApplicationBuilderExtensions.cs

javiercn force-pushed the javiercn/blazor-mapblazorframeworkfiles branch from 091c17f to f82f661 Compare February 20, 2020 15:41

Change MapBlazorWebAssemblyApplication to UseBlazorFrameworkFiles

e745d3a

javiercn force-pushed the javiercn/blazor-mapblazorframeworkfiles branch from f82f661 to e745d3a Compare February 20, 2020 15:52

javiercn marked this pull request as ready for review February 20, 2020 16:08

javiercn requested a review from SteveSandersonMS as a code owner February 20, 2020 16:08

Pilchie added the area-blazor Includes: Blazor, Razor Components label Feb 20, 2020