Skip to content

Fixup RuntimeDependenciesResolver test #19208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2020
Merged

Conversation

pranavkm
Copy link
Contributor

@pranavkm pranavkm commented Feb 20, 2020

  • Changed the test to be rooted on the standalone app (versus the test which has a different reference graph)
  • Use embedded resources which was easier to transfer around and should likely fix the helix issue.

Fixes #12059

@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Feb 20, 2020
@pranavkm pranavkm force-pushed the prkrishn/update-test branch from b92b666 to cdcbe44 Compare February 20, 2020 21:34
@pranavkm pranavkm requested a review from javiercn February 20, 2020 21:35
Copy link
Member

@javiercn javiercn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how you are fixing it, I think I understand the problem was we weren't traversing dependencies properly, but I'm not sure how you are fixing it.

I'm signing off because I trust you and I don't see anything wrong with the code/test changes, but in the future it would help if you can share a bit more details about the fix on the change description, as it was not clear to me what was going on.

@pranavkm
Copy link
Contributor Author

The issue was that we were using the ref assemblies for the test to walk the dependency graph for the standaloneapp. You get different results as a result of this since the test app is netcoreapp vs client which is a netstandard targeting app. Hope that helps.

@pranavkm pranavkm merged commit 4715de4 into blazor-wasm Feb 21, 2020
@pranavkm pranavkm deleted the prkrishn/update-test branch February 21, 2020 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants