Change SiteExtension reference #19218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrennanConroy
commented
Feb 21, 2020
dougbu
reviewed
Feb 21, 2020
|
We are seeing the same issue in the 'release/5.0-preview1' branch and need this fix there too. /cc @Pilchie @jkotalik @wtgodbe FYI root cause of this is unfortunate fact this part of the build isn't run when validating PRs. We may need to either
|
|
Should have mentioned; We (@JunTaoLuo IIRC but after some discussion) disabled the site extensions build step because it was adding extra time to PR validation and usually provided little value |
dougbu
approved these changes
Feb 21, 2020
|
|
Yep, I'm very aware :( |
Pilchie
added
the
area-infrastructure
jkotalik
reviewed
Feb 21, 2020
| <!-- When updating this add the previous SiteExtension(s) to the list above --> | ||
| <PackageReference Include="Microsoft.AspNetCore.AzureAppServices.SiteExtension.3.1.x64" Version="$(PackageVersion)-$(_PreReleaseLabel)" PrivateAssets="All" /> |
There was a problem hiding this comment.
Why were these a package reference before for 3.1?
BrennanConroy
added a commit
that referenced
this pull request
Feb 21, 2020
* Change SiteExtension reference * disable
wtgodbe
pushed a commit
that referenced
this pull request
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.