Plumb a clock interface through SignalR for testing #19311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halter73
reviewed
Feb 25, 2020
| { | ||
| _logger = loggerFactory.CreateLogger<HttpConnectionManager>(); | ||
| _connectionLogger = loggerFactory.CreateLogger<HttpConnectionContext>(); | ||
| _nextHeartbeat = new TimerAwaitable(_heartbeatTickRate, _heartbeatTickRate); | ||
| _disconnectTimeout = connectionOptions.Value.DisconnectTimeout ?? ConnectionOptionsSetup.DefaultDisconectTimeout; | ||
| if (AppContext.TryGetSwitch("Microsoft.AspNetCore.Http.Connections.DoNotUseSendTimeout", out var timeoutDisabled)) |
There was a problem hiding this comment.
It was only for patch branches
There was a problem hiding this comment.
I believe we do this in other places too. Like MVC
halter73
reviewed
Feb 25, 2020
|
|
||
| namespace Microsoft.AspNetCore.Internal | ||
| { | ||
| internal interface ISystemClock |
There was a problem hiding this comment.
Can we share this stuff with Kestrel?
There was a problem hiding this comment.
Probably, I did just copy it from Kestrel.
davidfowl
reviewed
Feb 25, 2020
src/SignalR/common/Http.Connections/src/Internal/HttpConnectionManager.cs
Outdated
Show resolved
Hide resolved
davidfowl
reviewed
Feb 25, 2020
| @@ -223,8 +223,6 @@ private async Task DispatchMessagesAsync(HubConnectionContext connection) | |||
| var result = await input.ReadAsync(); | |||
| var buffer = result.Buffer; | |||
|
|
|||
| connection.ResetClientTimeout(); | |||
There was a problem hiding this comment.
It's no longer needed with how we changed timeouts
davidfowl
reviewed
Feb 25, 2020
BrennanConroy
force-pushed
the
brecon/clock
branch
from
9bd96ee to
c68eadf
Compare
|
Ok, fixed this to be scoped to just HubConnectionHandler and set it in tests that want to control the clock. |
halter73
reviewed
Mar 31, 2020
src/SignalR/common/Http.Connections/src/Internal/HttpConnectionManager.cs
Show resolved
Hide resolved
halter73
approved these changes
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task.Delay(...)Not very happy with the compile includes, but didn't want to do internals visible to, or design a new public type.