Create WindowsPrincipal when cloning WindowsIdentity for SignalR #19337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halter73
reviewed
Feb 25, 2020
| } | ||
| else | ||
| { | ||
| newContext.User = new ClaimsPrincipal(); |
There was a problem hiding this comment.
Nit, to get rid of skipFirstIdentity
Suggested change
| newContext.User = new ClaimsPrincipal(); | |
| newContext.User = new ClaimsPrincipal(windowsIdentity.Clone()); |
There was a problem hiding this comment.
Think I have to keep it as is, because I still need to skip somehow when copying the rest of the identities.
There was a problem hiding this comment.
Wouldn't you just always skip? You could do something like oldContext.User.Identities.Skip(1), right?
There was a problem hiding this comment.
That allocates I believe
halter73
approved these changes
Feb 25, 2020
|
@anurse I noticed this PR is added to 5.0.0-preview2 milestone. Can something this small be shipped earlier than that, please? Thank you. 🙂 |
|
@bmoteria Unfortunately no, the preview1 branch is closed to new changes at this time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18560