Build fixups in master #19338
Merged
Build fixups in master #19338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pranavkm
commented
Feb 25, 2020
pranavkm
commented
- Fix error with nullable
- Commit yarn.lock produced from building Microsoft.InteropJS
pranavkm
commented
Feb 25, 2020
| @@ -42,39 +42,39 @@ public bool TryFindElementById(string id, [NotNullWhen(true)] out ElementNode? e | |||
| foreach (var kvp in Components) | |||
| { | |||
| var component = kvp.Value; | |||
| if (TryGetElementFromChildren(component, out element)) | |||
| if (TryGetElementFromChildren(component, id, out element)) | |||
| { | |||
| return true; | |||
There was a problem hiding this comment.
This complains because element isn't guaranteed to be non-null. Only appears when building in VS
pranavkm
commented
Feb 25, 2020
| @@ -0,0 +1,258 @@ | |||
| # THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY. | |||
There was a problem hiding this comment.
@JunTaoLuo does the package.json need to be removed?
There was a problem hiding this comment.
You mean the package.lock.json? Then you can remove it if you'd like.
There was a problem hiding this comment.
Yeah, you're right, the lock file.
* Fix error with nullable * Commit yarn.lock produced from building Microsoft.InteropJS
pranavkm
force-pushed
the
prkrishn/fixup-notnull
branch
from
293e8d7 to
3177f2d
Compare
SteveSandersonMS
approved these changes
Feb 26, 2020
Pilchie
added
the
area-infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.