Update BenchmarkDotNet and add Http2Connection benchmark #19482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
requested review from
analogrelay,
dougbu,
halter73,
jkotalik and
Tratcher
as code owners
JamesNK
added
the
area-infrastructure
|
Talked with @sebastienros and only thing external tools care about is the CSV output which should be unchanged. |
jkotalik
approved these changes
Mar 3, 2020
JamesNK
force-pushed
the
jamesnk/http2-connection-benchmark
branch
from
5575be7 to
60dd0ca
Compare
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a high-level Http2Connection benchmark
I found that BenchmarkDotNet was not correctly measuring allocations, I'm guessing because they're happening in the connection event loop thread and not the benchmark thread.
Our BenchmarkDotNet version is over two years old. Updating it to the latest version correctly measures allocations.
Does BenchmarkDotNet in this repo have any external callers?