Support nullable enum in InputSelect #19506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Thanks for your PR, @GuillaumeNury. |
mkArtakMSFT
requested review from
pranavkm
and removed request for
SteveSandersonMS
|
|
|
I have added some tests. Feel free to tell me if anything needs to be added. |
pranavkm
suggested changes
Mar 5, 2020
| @@ -18,7 +18,7 @@ public abstract class InputBase<TValue> : ComponentBase, IDisposable | |||
| private readonly EventHandler<ValidationStateChangedEventArgs> _validationStateChangedHandler; | |||
| private bool _previousParsingAttemptFailed; | |||
| private ValidationMessageStore _parsingValidationMessages; | |||
| private Type _nullableUnderlyingType; | |||
| protected Type _nullableUnderlyingType; | |||
There was a problem hiding this comment.
This is a change to the public API surface and would need to go through an API review. This would mean changing this a property and documenting it, and I still don't think we would want to expose this on the API.
A much cheaper option would be to calculate this as a field in the InputSelect<TValue> type.
public class InputSelect<TValue> : InputBase<TValue>
{
private readonly Type _nullableUnderlyingType = Nullable.GetUnderlyingType(typeof(TValue));
..
There was a problem hiding this comment.
Indeed ! I reverted that and used your solution.
GuillaumeNury
force-pushed
the
input-select-nullable-enum
branch
from
a0c4741 to
000d86e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
BindConvertersupports Nullable enums (here), call it if the underlying type has type of enum.Addresses #13624