[Helix] Reenable some template tests again #19520
Conversation
ghost
added
the
area-infrastructure
HaoK
force-pushed
the
haok/check
branch
2 times, most recently
from
336b6df to
ba41c26
Compare
|
Marking for review again, the issue before was a path issue on Win 8.1, Java had parens in the path which caused issues, delay expansion fixes that. There look to be some failing tests now which are unrelated. |
|
I will undo the commented out PR guards before merging, needed to verify the PR against all queues |
There was a problem hiding this comment.
Verification not looking great though the template tests look good. May want to rebase on 'master' if last run missed the latest Kestrel in-memory test fixes / quarantining (@anurse @BrennanConroy❔)
| @@ -107,7 +107,7 @@ private async Task MvcTemplateCore(string languageOverride) | |||
| [ConditionalTheory] | |||
| [InlineData(true)] | |||
| [InlineData(false)] | |||
| [SkipOnHelix("ef restore no worky")] | |||
| [SkipOnHelix("cert failure", Queues = "OSX.1014.Amd64;OSX.1014.Amd64.Open")] | |||
There was a problem hiding this comment.
Would this problem go away if we were testing against the final SDK i.e. w/ notarized packages for Catalina?
There was a problem hiding this comment.
No idea, I'm not familiar with what the cert requirements are, I don't think we had this issue on the azdo machines tho, so probably something specific to the helix macs
|
Okay I'm going to remove the full helix queues and see if this PR goes green, I'm seeing some signalr/server tests consistently fail on the larger queues, but they have nothing to do with templates |
HaoK
force-pushed
the
haok/check
branch
2 times, most recently
from
50f456f to
d12c25b
Compare
|
@anurse @BrennanConroy have you guys seen any issues with this test? Microsoft.AspNetCore.SignalR.Tests.HubConnectionHandlerTests.ReceivingMessagesPreventsConnectionTimeoutFromOccuring I keep seeing it fail on this PR, i've rebased a few times and retried like 3-4 times and no luck. The console logs don't seem to load either, so no idea... thoughts? |
|
That test has been quarantined. Did you rebase on master correctly? Is quarantine somehow broken? |
|
I would guess you're not using |
|
Okay looks like we can get away with just disabling enabledelayedexpansion rather than all extensions, the new java stuff in the path messes things up with parens on Win8.1, which is why we need enabledelayedexpansion now. Everything is passing now, @dougbu can you review again |
See what template tests are failing