fix #19571 by removing dataprotection.azure packages #19572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Pilchie
approved these changes
Mar 4, 2020
analogrelay
force-pushed
the
anurse/remove-old-azure-packagees
branch
from
bc97556 to
0cc3890
Compare
|
Rebaséd |
dougbu
approved these changes
Mar 4, 2020
src/DataProtection/AzureKeyVault/src/Microsoft.AspNetCore.DataProtection.AzureKeyVault.csproj
Show resolved
Hide resolved
src/DataProtection/AzureStorage/src/Microsoft.AspNetCore.DataProtection.AzureStorage.csproj
Show resolved
Hide resolved
|
I think we're ready to go here. I'll rebase and resolve conflicts and if we get a green build I plan to merge. |
analogrelay
force-pushed
the
anurse/remove-old-azure-packagees
branch
from
0cc3890 to
d0ca8f3
Compare
This comment has been minimized.
This comment has been minimized.
|
Ported to preview2 and now have to rebase and respin builds :(. |
analogrelay
force-pushed
the
anurse/remove-old-azure-packagees
branch
from
d0ca8f3 to
57922c7
Compare
|
Had to do battle with merge conflicts on the version files. I think I can claim victory now. There should be no changes to versions in this PR, just removed dependencies. |
|
Windows test build hanged? |
|
IT PASSED?! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19571
I'm pretty sure I probably missed something so we'll see what the CI does. As per aspnet/Announcements#408 we will be removing these packages in 5.0 since the Azure SDK team is taking them over (with new package IDs). This PR removes the DataProtection.Azure packages and pre-emptively removes references to Microsoft.Extensions.Configuration.AzureKeyVault (which will be removed in dotnet/extensions#3057).
I probably missed something but the CI will be more effective at finding it that I am :).
TODO before merging: