Skip to content

[Blazor] API cleanups for the authentication Package #19601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
3 commits merged into from
Mar 5, 2020

Conversation

javiercn
Copy link
Member

@javiercn javiercn commented Mar 5, 2020

  • Add a couple of missing options to the OidcProviderOptions
  • Remove string based APIs in favor of enums.

I didn't change RemoteAuthenticationActions to an enum for the following reasons:

  • It is used as a parameter on the URL, and we don't want to tie the value used in the url to whether or not we can "cast to it". One option we can try here is to create a struct instead of an enum to represent it and have it hold the right value we can then use an implicit converter to cast to it, but I don't know if that will work.
  • We still need to expose the string values of it, as they are part of the url, so we don't actually reduce the public API surface

@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Mar 5, 2020
@javiercn javiercn force-pushed the javiercn/blazor-auth-api-cleanups branch from 2956355 to e04c39a Compare March 5, 2020 13:50
@ghost
Copy link

ghost commented Mar 5, 2020

Hello @pranavkm!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 60 minutes, a condition that will be fulfilled in about 41 seconds. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 28c44ce into blazor-wasm Mar 5, 2020
@ghost ghost deleted the javiercn/blazor-auth-api-cleanups branch March 5, 2020 14:47
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants