-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Skip Interop.FunctionalTests on arm #19648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn’t seem great to not run these tests on PRs.
It's not great, I agree, but it's a constraint we have. The ARM machines are physical and can't just be scaled up and down. We've been asked to keep our ARM usage fairly minimal. I probably should have been more proactive and checked that these tests had a binary dependency, but things like this will get missed. It's a trade-off. |
Stand by. Rebased the PR, now rebasing the branch. |
there's no h2spec build for it
a9c5dc4
to
2c4260a
Compare
Rebased. |
Override merging now as per justification above. |
Can we get this change merged into |
Sure, I'll open a merge PR to try and pull this format. Should we just merge preview2 and merge to master now? |
We have #19655 (comment) going. I'll take a look at it. |
There's no h2spec build for it, so it fails.
We don't run arm64 builds in our PRs which is a) why the original PR to enable these tests didn't catch this and b) why this PR's checks are mostly moot.
If I get a successful build leg (to make sure I didn't mess that up), I may just force-merge this to unblock builds. Does that sound reasonable @dotnet/aspnet-build ?