Skip to content

Change quic package name to experiemental #19657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 9, 2020

Conversation

jkotalik
Copy link
Contributor

@jkotalik jkotalik commented Mar 6, 2020

We'd like to make it clear that QUIC support is still experimental in ASP.NET Core. Changing the package name and namespace to indicate that.

cc @Pilchie @anurse

@jkotalik
Copy link
Contributor Author

jkotalik commented Mar 6, 2020

@anurse I didn't change the call to UseQuic (rather than UseExperimentalQuic). Is that okay with you.

I went to the artifacts and verified the packages are produced:
image

@jkotalik
Copy link
Contributor Author

jkotalik commented Mar 7, 2020

@anurse / @Pilchie anything else I need to do to get approval to merge this? I don't have permission to merge so someone else will need to.

@Pilchie
Copy link
Member

Pilchie commented Mar 9, 2020

LGTM - do you want it squashed?

@jkotalik
Copy link
Contributor Author

jkotalik commented Mar 9, 2020

Squash please :)

@Pilchie Pilchie merged commit 3a971ef into release/5.0-preview2 Mar 9, 2020
@Pilchie Pilchie deleted the jkotalik/experimentalQuic branch March 9, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants