Avoid string allocation when converting zero #19732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
requested review from
analogrelay,
jkotalik and
Tratcher
as code owners
analogrelay
reviewed
Mar 10, 2020
| @@ -562,6 +562,11 @@ public unsafe static string FormatNonNegativeInt64(long value) | |||
| throw new ArgumentOutOfRangeException(nameof(value), value, "The value to be formatted must be non-negative."); | |||
| } | |||
|
|
|||
| if (value == 0) | |||
There was a problem hiding this comment.
If it is stupid and it works, is it really stupid? 🐴
jkotalik
approved these changes
Mar 10, 2020
halter73
approved these changes
Mar 11, 2020
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19731