Skip to content

[blazor-wasm] Ensure PDBArtifacts artifact is created #19837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2020

Conversation

dougbu
Copy link
Contributor

@dougbu dougbu commented Mar 13, 2020

  • dotnet/aspnetcore-internal#3535
  • avoid build warnings when publishing symbols in post-build

@dougbu dougbu requested review from pranavkm and a team March 13, 2020 18:43
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Mar 13, 2020
Copy link
Contributor

@pranavkm pranavkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you think this is the right fix. I'm not entirely sure why pdbs are missing though.

@dougbu
Copy link
Contributor Author

dougbu commented Mar 13, 2020

@dougbu
Copy link
Contributor Author

dougbu commented Mar 13, 2020

https://dev.azure.com/dnceng/internal/_build/results?buildId=558785&view=artifacts&type=publishedArtifacts shows build created the PDBArtifacts artifact.

I forgot to create a default channel for my branch to ensure the missing artifact was the only problem causing the "issues" in our official builds. Tried again and also asked @JohnTortugo to execute darc add-build-to-channel --id 45804 --channel 'General Testing' for me, providing two chances to see symbol publication "succeed" (do nothing). Thanks @JohnTortugo

The real build (https://dev.azure.com/dnceng/internal/_build/results?buildId=558921) ran fine but still didn't try to push anything into the 'General Testing' feeds. Not sure why but maybe that channel doesn't exist in the older version of Arcade used in this branch (it's 143 commits behind 'blazor-wasm' and I built the branch directly instead of creating an internal PR)?

The promotion build https://dnceng.visualstudio.com/internal/_build/results?buildId=558940 succeeded without issues and definitely found the PDBArtifacts artifact (see https://dnceng.visualstudio.com/internal/_build/results?buildId=558940&view=logs&j=65907e9e-dc2e-508d-4ed4-c5ec62867dbe&t=27af53db-dc59-5d1e-3865-33df1e36904b&l=177). So, we're good😺

@dougbu
Copy link
Contributor Author

dougbu commented Mar 13, 2020

Will merge this once I prepare no-op merge PRs for 'release/3.1' and 'master' branches.

- dotnet/aspnetcore-internal#3535
- avoid build warnings when publishing symbols in post-build
@dougbu dougbu force-pushed the dougbu/no.xdt/3535 branch from 5bf3451 to b1f039d Compare March 14, 2020 01:57
@dougbu
Copy link
Contributor Author

dougbu commented Mar 14, 2020

🆙📅 to move my git merge-base back to include a 'release/3.1' common ancestor. No functional changes included.

This update avoids marking ~65 'blazor-wasm' commits as being present in the 'release/3.1' branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants