Don't ship Wasm.Performance.Driver #19903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
mkArtakMSFT
approved these changes
Mar 16, 2020
|
Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge. |
mkArtakMSFT
added
Servicing-approved
|
@pranavkm please also merge this into release/5.0-preview2. |
pranavkm
force-pushed
the
pranavkm-patch-3
branch
from
6f6b9e5 to
fef630e
Compare
pranavkm
commented
Mar 16, 2020
| @@ -6,6 +6,8 @@ | |||
|
|
|||
| <HasReferenceAssembly>false</HasReferenceAssembly> | |||
| <IsProjectReferenceProvider>false</IsProjectReferenceProvider> | |||
| <IsShippingPackage>false</IsShippingPackage> | |||
There was a problem hiding this comment.
@dotnet/aspnet-build does this look correct?
There was a problem hiding this comment.
@wtgodbe has confirmed (during an offline conversation) that this is the right fix: <IsShippingPackage>false</IsShippingPackage>
wtgodbe
approved these changes
Mar 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.